Message ID | 1422835088-11852-1-git-send-email-bluemrp9@gmail.com |
---|---|
State | Accepted |
Headers | show |
Dear Ryan Coe, On Sun, 1 Feb 2015 16:58:08 -0700, Ryan Coe wrote: > Without these environment variables, pps-tools rebuilds for the host machine > architecture and does not run on the target machine. > > Signed-off-by: Ryan Coe <bluemrp9@gmail.com> > --- > package/pps-tools/pps-tools.mk | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied, thanks. We just discussed here at the Buildroot meeting that we should probably add a post-build check that verifies that all binaries that have been installed to the root filesystem are actually built for the correct architecture. Thanks for the report and patch! Thomas
diff --git a/package/pps-tools/pps-tools.mk b/package/pps-tools/pps-tools.mk index 7876403..48feea9 100644 --- a/package/pps-tools/pps-tools.mk +++ b/package/pps-tools/pps-tools.mk @@ -16,12 +16,14 @@ endef define PPS_TOOLS_INSTALL_STAGING_CMDS mkdir -p $(STAGING_DIR)/usr/include/sys $(STAGING_DIR)/usr/bin - $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(STAGING_DIR) -C $(@D) install + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \ + DESTDIR=$(STAGING_DIR) -C $(@D) install endef define PPS_TOOLS_INSTALL_TARGET_CMDS mkdir -p $(TARGET_DIR)/usr/include/sys $(TARGET_DIR)/usr/bin - $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \ + DESTDIR=$(TARGET_DIR) -C $(@D) install endef $(eval $(generic-package))
Without these environment variables, pps-tools rebuilds for the host machine architecture and does not run on the target machine. Signed-off-by: Ryan Coe <bluemrp9@gmail.com> --- package/pps-tools/pps-tools.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)