Message ID | 1422584076-5728-2-git-send-email-arei.gonglei@huawei.com |
---|---|
State | New |
Headers | show |
On 01/29/15 21:14, arei.gonglei@huawei.com wrote: > From: Gonglei <arei.gonglei@huawei.com> > > Add missing vnc options: to, ipv4, ipv6 and fix > qemu crash. > > Reproducer: > $ x86_64-softmmu/qemu-system-x86_64 > qemu-system-x86_64: Invalid parameter 'to' > Segmentation fault (core dumped) > > BTW the patch fix the below bug: > https://bugs.launchpad.net/qemu/+bug/1414222 > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > --- Looks good, Reviewed-by: Don Slutz <dslutz@verizon.com> -Don Slutz > ui/vnc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/ui/vnc.c b/ui/vnc.c > index a742c90..08b8b24 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3276,6 +3276,15 @@ static QemuOptsList qemu_vnc_opts = { > .name = "connections", > .type = QEMU_OPT_NUMBER, > },{ > + .name = "to", > + .type = QEMU_OPT_NUMBER, > + },{ > + .name = "ipv4", > + .type = QEMU_OPT_BOOL, > + },{ > + .name = "ipv6", > + .type = QEMU_OPT_BOOL, > + },{ > .name = "password", > .type = QEMU_OPT_BOOL, > },{ >
diff --git a/ui/vnc.c b/ui/vnc.c index a742c90..08b8b24 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3276,6 +3276,15 @@ static QemuOptsList qemu_vnc_opts = { .name = "connections", .type = QEMU_OPT_NUMBER, },{ + .name = "to", + .type = QEMU_OPT_NUMBER, + },{ + .name = "ipv4", + .type = QEMU_OPT_BOOL, + },{ + .name = "ipv6", + .type = QEMU_OPT_BOOL, + },{ .name = "password", .type = QEMU_OPT_BOOL, },{