diff mbox

vnc: fix qemu crash when not configure vnc option

Message ID 1422523660-11160-1-git-send-email-arei.gonglei@huawei.com
State New
Headers show

Commit Message

Gonglei (Arei) Jan. 29, 2015, 9:27 a.m. UTC 
From: Gonglei <arei.gonglei@huawei.com>

Reproducer:
$ x86_64-softmmu/qemu-system-x86_64
qemu-system-x86_64: Invalid parameter 'to'
Segmentation fault (core dumped)

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
 ui/vnc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Gonglei (Arei) Jan. 29, 2015, 12:55 p.m. UTC | #1 
On 2015/1/29 17:27, Gonglei (Arei) wrote:

> From: Gonglei <arei.gonglei@huawei.com>
> 
> Reproducer:
> $ x86_64-softmmu/qemu-system-x86_64
> qemu-system-x86_64: Invalid parameter 'to'
> Segmentation fault (core dumped)
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  ui/vnc.c | 3 +++
>  1 file changed, 3 insertions(+)

Please ignore this patch which is incomplete.
I have posted other simply patch series for this issue.

Regards,
-Gonglei
diff mbox

Patch

diff --git a/ui/vnc.c b/ui/vnc.c
index a742c90..acff482 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3276,6 +3276,9 @@  static QemuOptsList qemu_vnc_opts = {
             .name = "connections",
             .type = QEMU_OPT_NUMBER,
         },{
+            .name = "to",
+            .type = QEMU_OPT_NUMBER,
+        },{
             .name = "password",
             .type = QEMU_OPT_BOOL,
         },{