| Message ID | 1422495374-22835-1-git-send-email-behanw@converseincode.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Behan Webster <behanw@converseincode.com> Date: Wed, 28 Jan 2015 17:36:14 -0800 > Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. > > Signed-off-by: Behan Webster <behanw@converseincode.com> > Suggested-by: Arnd Bergmann <arnd@arndb.de> Why are you removing the device table? Second of all, your Subject needs to be adjusted, using "net" and "LLVMLinux" in your subsystem prefix is not appropriate. Simply "be2net: ", the name of this driver, is sufficient. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 28 January 2015 22:42:28 David Miller wrote: > From: Behan Webster <behanw@converseincode.com> > Date: Wed, 28 Jan 2015 17:36:14 -0800 > > > Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. > > > > Signed-off-by: Behan Webster <behanw@converseincode.com> > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > > Why are you removing the device table? Behan took a patch that I did earlier and split it up to add descriptions. The patch is correct, but he either misunderstood or misexpressed the intention. This driver has two identical lines that both say MODULE_DEVICE_TABLE(pci, be_dev_ids); I don't remember the exact symptom, but llvm/clang trips over this, while gcc silently ignores the second one. Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnd Bergmann <arnd@arndb.de> writes: > On Wednesday 28 January 2015 22:42:28 David Miller wrote: >> From: Behan Webster <behanw@converseincode.com> >> Date: Wed, 28 Jan 2015 17:36:14 -0800 >> >> > Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. >> > >> > Signed-off-by: Behan Webster <behanw@converseincode.com> >> > Suggested-by: Arnd Bergmann <arnd@arndb.de> >> >> Why are you removing the device table? > > Behan took a patch that I did earlier and split it up to add descriptions. > The patch is correct, but he either misunderstood or misexpressed the > intention. > > This driver has two identical lines that both say > > MODULE_DEVICE_TABLE(pci, be_dev_ids); > > I don't remember the exact symptom, but llvm/clang trips over this, while gcc > silently ignores the second one. GCC is probably being "helpful" and allowing multiple identical definitions even though the C spec does not. Obviously all but one should go away. No need to mention llvm, IMO.
On 01/29/15 01:10, Arnd Bergmann wrote: > On Wednesday 28 January 2015 22:42:28 David Miller wrote: >> From: Behan Webster <behanw@converseincode.com> >> Date: Wed, 28 Jan 2015 17:36:14 -0800 >> >>> Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. >>> >>> Signed-off-by: Behan Webster <behanw@converseincode.com> >>> Suggested-by: Arnd Bergmann <arnd@arndb.de> >> Why are you removing the device table? > Behan took a patch that I did earlier and split it up to add descriptions. > The patch is correct, but he either misunderstood or misexpressed the > intention. I was tired and rushed this submission in my preparation for FOSDEM. Apologies to all. I neglected to write the commit log when I first split the patch, and didn't look hard enough this time. > This driver has two identical lines that both say > > MODULE_DEVICE_TABLE(pci, be_dev_ids); This is indeed the case. > I don't remember the exact symptom, but llvm/clang trips over this, while gcc > silently ignores the second one. It claims that it is defined more than once. Behan
On 01/28/15 22:42, David Miller wrote: > From: Behan Webster <behanw@converseincode.com> > Date: Wed, 28 Jan 2015 17:36:14 -0800 > >> Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. >> >> Signed-off-by: Behan Webster <behanw@converseincode.com> >> Suggested-by: Arnd Bergmann <arnd@arndb.de> > Why are you removing the device table? It is defined more than once; removing the duplicate (as Arnd indicated). My commit message was just completely wrong. Brain fart. Sorry. > Second of all, your Subject needs to be adjusted, using "net" and > "LLVMLinux" in your subsystem prefix is not appropriate. Simply > "be2net: ", the name of this driver, is sufficient. Will fix. I've been in the habit of labelling the patches which go through the LLVMLinux project like this so they are trivially identifiable in the subject on lkml for reviewers and in the git log as being patches which exist because of clang. If it's annoying I certainly don't need to do it. Behan
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index d48806b..709400a 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -26,7 +26,6 @@ #include <net/vxlan.h> MODULE_VERSION(DRV_VER); -MODULE_DEVICE_TABLE(pci, be_dev_ids); MODULE_DESCRIPTION(DRV_DESC " " DRV_VER); MODULE_AUTHOR("Emulex Corporation"); MODULE_LICENSE("GPL");
Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. Signed-off-by: Behan Webster <behanw@converseincode.com> Suggested-by: Arnd Bergmann <arnd@arndb.de> Cc: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/emulex/benet/be_main.c | 1 - 1 file changed, 1 deletion(-)