Message ID | 54C9654C.8030407@ti.com |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show |
On 01/28/2015 05:40 PM, Murali Karicheri wrote: > + Felipe, Mugunthan for commenting on TI_CPSW, ALE. > --- Cut ------ > >> >> The second problem is where I got stuck myself: cpsw_ale.c (also cpts.c) >> is getting linked into both modules, which is not allowed: It is >> impossible for the kernel to compile these if one driver is a module >> and the other one is not, and any use of KBUILD_MODNAME fails because >> it is unclear what the modname is if the file is compiled once to >> be linked into two drivers. Arnd, I think the solution is to make the cpsw_ale as a module and configured through a Kconfig option. I am working on a fix for this now. Similar fix is required for cpts.o. Currently we are not using this module for Netcp, but soon this will be re-used. I have send a patch that is already applied to net-next removing cpts.o for Netcp. Murali > > I am still looking into this. Both Keystone and TI CPSW driver would > need to use cpsw_ale.o and cpts.o (currently not used, but will need > this later). Not found a solution yet. > > Murali >> >> Arnd > >
On Thursday 29 January 2015 12:21:36 Murali Karicheri wrote: > > I think the solution is to make the cpsw_ale as a module and configured > through a Kconfig option. I am working on a fix for this now. > > Similar fix is required for cpts.o. Currently we are not using this > module for Netcp, but soon this will be re-used. I have send a patch > that is already applied to net-next removing cpts.o for Netcp. > Great, thanks a lot for the follow-up. Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/29/2015 05:00 PM, Arnd Bergmann wrote: > On Thursday 29 January 2015 12:21:36 Murali Karicheri wrote: >> >> I think the solution is to make the cpsw_ale as a module and configured >> through a Kconfig option. I am working on a fix for this now. >> >> Similar fix is required for cpts.o. Currently we are not using this >> module for Netcp, but soon this will be re-used. I have send a patch >> that is already applied to net-next removing cpts.o for Netcp. >> > > Great, thanks a lot for the follow-up. > > Arnd Arnd, I have just posted a patch to nedev list to address this issue. Please review and let me know your comments. This also require some additional fixes in drivers/soc/ti/ to build them as modules as well. Santosh has queued them against next merge window. Felipe, Mugunthan, As the patch touches ti_cpsw as well, please review and provide your comments. It will be great if you can apply this patch on net-next branch and test it on ti platform using ti_cpsw driver.
On Thursday 29 January 2015 18:20:24 Murali Karicheri wrote: > > I have just posted a patch to nedev list to address this issue. Please > review and let me know your comments. This also require some additional > fixes in drivers/soc/ti/ to build them as modules as well. Santosh has > queued them against next merge window. Ok, thanks for addressing this! As I wrote in reply to your patch, I'll give it some extra build testing in random configurations. Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/ti/Makefile b/drivers/net/ethernet/ti/Makefile index 0a9813b..1dbb8b5 100644 --- a/drivers/net/ethernet/ti/Makefile +++ b/drivers/net/ethernet/ti/Makefile @@ -8,9 +8,13 @@ obj-$(CONFIG_TI_DAVINCI_EMAC) += davinci_emac.o obj-$(CONFIG_TI_DAVINCI_MDIO) += davinci_mdio.o obj-$(CONFIG_TI_DAVINCI_CPDMA) += davinci_cpdma.o obj-$(CONFIG_TI_CPSW_PHY_SEL) += cpsw-phy-sel.o obj-$(CONFIG_TI_CPSW) += ti_cpsw.o ti_cpsw-y := cpsw_ale.o cpsw.o cpts.o obj-$(CONFIG_TI_KEYSTONE_NETCP) += keystone_netcp.o -keystone_netcp-y := netcp_core.o netcp_ethss.o netcp_sgmii.o \ - netcp_xgbepcsr.o cpsw_ale.o +keystone_netcp-y := netcp_core.o + +obj-$(CONFIG_TI_KEYSTONE_NETCP_ETHSS) += keystone_netcp_ethss.o +keystone_netcp_ethss-y := netcp_ethss.o netcp_sgmii.o netcp_xgbepcsr.o \ + cpsw_ale.o