Patchwork [2/2] enic: Fix Kconfig headline description

login
register
mail settings
Submitter Roland Dreier
Date Oct. 13, 2008, 8:36 p.m.
Message ID <adaej2kp701.fsf@cisco.com>
Download mbox | patch
Permalink /patch/4341/
State Accepted
Delegated to: David Miller
Headers show

Comments

Roland Dreier - Oct. 13, 2008, 8:36 p.m.
From: Scott Feldman <scofeldm@cisco.com>

I don't think the enic driver has anything to do with Mark Everett
(http://en.wikipedia.org/wiki/A_Man_Called_E).  Fix the Kconfig
description.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
And this is the other half of
https://kerneltrap.org/mailarchive/linux-netdev/2008/9/20/3350614/thread
that seems to have gotten dropped.  Please apply.

 drivers/net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 14, 2008, 1:53 a.m.
From: Roland Dreier <rdreier@cisco.com>
Date: Mon, 13 Oct 2008 13:36:30 -0700

> I don't think the enic driver has anything to do with Mark Everett
> (http://en.wikipedia.org/wiki/A_Man_Called_E).  Fix the Kconfig
> description.
> 
> Signed-off-by: Roland Dreier <rolandd@cisco.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Oct. 16, 2008, 9:30 a.m.
Roland Dreier wrote:
> From: Scott Feldman <scofeldm@cisco.com>
> 
> I don't think the enic driver has anything to do with Mark Everett
> (http://en.wikipedia.org/wiki/A_Man_Called_E).  Fix the Kconfig
> description.
> 
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> And this is the other half of
> https://kerneltrap.org/mailarchive/linux-netdev/2008/9/20/3350614/thread
> that seems to have gotten dropped.  Please apply.
> 
>  drivers/net/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index e9d5294..1d8af33 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2400,7 +2400,7 @@ config EHEA
>  	  will be called ehea.
>  
>  config ENIC
> -	tristate "E, the Cisco 10G Ethernet NIC"
> +	tristate "Cisco 10G Ethernet NIC support"
>  	depends on PCI && INET

Sheesh, Cisco just does not have any sense of humor :)

As I explained to Scott (in private email, unfortunately, IIRC), I did 
that so that it would fit in the list alphabetized -- Scott placed it in 
the section with the E's, not the C's.

Furthermore, "Cisco 10G ethernet nic" is a vague description if Cisco 
ever plans to sell another ethernet product.  Will the next one be 
"Cisco 10G Ethernet NIC, the sequel"?  :)

If you insist on such an incredibly boring description, at least put it 
into the section with the 'C' not the 'E'.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roland Dreier - Oct. 16, 2008, 10:43 p.m.
> Sheesh, Cisco just does not have any sense of humor :)

Hey I thought name-checking Mark Everett in the changelog was kind of funny.

 > As I explained to Scott (in private email, unfortunately, IIRC), I did
 > that so that it would fit in the list alphabetized -- Scott placed it
 > in the section with the E's, not the C's.

Unfortunately Dave already applied my patch (and somehow dropped the
"From: Scott" part of my email so I get blamed ;).  I didn't realize the
list was alphabetized -- I guess we should add another patch to put this
in the right place in the list?

 > Furthermore, "Cisco 10G ethernet nic" is a vague description if Cisco
 > ever plans to sell another ethernet product.  Will the next one be
 > "Cisco 10G Ethernet NIC, the sequel"?  :)

I guess we're just counting on being on to 100G ethernet by the time we
do another NIC... but seriously we should probably figure out what the
marketing name will be and improve the help text.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Oct. 27, 2008, 6:43 p.m.
Roland Dreier wrote:
>  > Sheesh, Cisco just does not have any sense of humor :)
> 
> Hey I thought name-checking Mark Everett in the changelog was kind of funny.
> 
>  > As I explained to Scott (in private email, unfortunately, IIRC), I did
>  > that so that it would fit in the list alphabetized -- Scott placed it
>  > in the section with the E's, not the C's.
> 
> Unfortunately Dave already applied my patch (and somehow dropped the
> "From: Scott" part of my email so I get blamed ;).  I didn't realize the
> list was alphabetized -- I guess we should add another patch to put this
> in the right place in the list?

Low priority, but, yes please.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index e9d5294..1d8af33 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2400,7 +2400,7 @@  config EHEA
 	  will be called ehea.
 
 config ENIC
-	tristate "E, the Cisco 10G Ethernet NIC"
+	tristate "Cisco 10G Ethernet NIC support"
 	depends on PCI && INET
 	select INET_LRO
 	help