Patchwork [1/2] enic: Fix build without _HAVE_ARCH_IPV6_CSUM

login
register
mail settings
Submitter Roland Dreier
Date Oct. 13, 2008, 8:35 p.m.
Message ID <adafxn0p71x.fsf@cisco.com>
Download mbox | patch
Permalink /patch/4340/
State Superseded
Delegated to: David Miller
Headers show

Comments

Roland Dreier - Oct. 13, 2008, 8:35 p.m.
From: Scott Feldman <scofeldm@cisco.com>

On architectures (such as powerpc) that don't define
_HAVE_ARCH_IPV6_CSUM, the enic compile fails with

    drivers/net/enic/enic_main.c: In function 'enic_queue_wq_skb_tso':
    drivers/net/enic/enic_main.c:575: error: implicit declaration of function 'csum_ipv6_magic'

Fix this by including <net/ip6_checksum.h>

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
Jeff, this is part of a patch Scott sent a while ago
(https://kerneltrap.org/mailarchive/linux-netdev/2008/9/20/3350614/thread)
that seems to have gotten dropped.  Please apply.

 drivers/net/enic/enic_main.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 14, 2008, 1:51 a.m.
From: Roland Dreier <rdreier@cisco.com>
Date: Mon, 13 Oct 2008 13:35:22 -0700

> From: Scott Feldman <scofeldm@cisco.com>
> 
> On architectures (such as powerpc) that don't define
> _HAVE_ARCH_IPV6_CSUM, the enic compile fails with
> 
>     drivers/net/enic/enic_main.c: In function 'enic_queue_wq_skb_tso':
>     drivers/net/enic/enic_main.c:575: error: implicit declaration of function 'csum_ipv6_magic'
> 
> Fix this by including <net/ip6_checksum.h>
> 
> Signed-off-by: Roland Dreier <rolandd@cisco.com>

I already received a fix for this seperately in my tree from
Kamalesh Babulal.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index f3a47a8..80119c9 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -35,6 +35,8 @@ 
 #include <linux/ipv6.h>
 #include <linux/tcp.h>
 
+#include <net/ip6_checksum.h>
+
 #include "cq_enet_desc.h"
 #include "vnic_dev.h"
 #include "vnic_intr.h"