Patchwork [#upstream-fixes] libata-sff: remove CONFIG_NO_ATA_LEGACY

login
register
mail settings
Submitter Tejun Heo
Date Jan. 21, 2010, 12:14 a.m.
Message ID <4B579C4A.3040907@gmail.com>
Download mbox | patch
Permalink /patch/43399/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - Jan. 21, 2010, 12:14 a.m.
CONFIG_NO_ATA_LEGACY isn't used by anyone.  Drop it.

Reported-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
---
On 01/20/2010 11:29 PM, Christoph Egger wrote:
> 	That's the only place where it is checked for
> NO_ATA_LEGACY. As this Item does appear nowhere in KConfig and
> therefor is not selectable I'm wondering whether that small Code
> fragment should be dropped or a new KConfig option should be added?
> 
> 	Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.

It's supposed to be set by architecture code to prevent SFF controller
attach if it's in legacy mode.  There apparently is no user left.
Trying to find the last user... it seems it hasn't been unused for at
least two year.  I guess it can be removed then.

Thanks!

 drivers/ata/libata-sff.c |    9 ---------
 1 file changed, 9 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Jan. 21, 2010, 4:32 a.m.
On 01/20/2010 07:15 PM, Tejun Heo wrote:
> Oops, Jeff, please send this #upstream.  I was thinking #upstream but
> my fingers had their own mind.  Thanks.

yep, definitely #upstream material...


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Cox - Jan. 21, 2010, 12:04 p.m.
On Thu, 21 Jan 2010 09:14:02 +0900
Tejun Heo <htejun@gmail.com> wrote:

> CONFIG_NO_ATA_LEGACY isn't used by anyone.  Drop it.
> 
> Reported-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
> Signed-off-by: Tejun Heo <tj@kernel.org>

Not unless this is cleared with the FRV maintainers who were using
it and I believe may still need it.

Mr Howells ?


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tejun Heo - Jan. 22, 2010, 12:48 a.m.
(cc'ing David Howells, who BTW is on vacation till Feb) Hi!

On 01/21/2010 09:04 PM, Alan Cox wrote:
> On Thu, 21 Jan 2010 09:14:02 +0900
> Tejun Heo <htejun@gmail.com> wrote:
> 
>> CONFIG_NO_ATA_LEGACY isn't used by anyone.  Drop it.
>>
>> Reported-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
> 
> Not unless this is cleared with the FRV maintainers who were using
> it and I believe may still need it.
> 
> Mr Howells ?

David, the patch in question is,

  http://lkml.org/lkml/2010/1/20/396

Does FRV still need it?

Thanks.

Patch

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 741065c..b9df435 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -2945,15 +2945,6 @@  int ata_pci_sff_activate_host(struct ata_host *host,
 		mask = (1 << 2) | (1 << 0);
 		if ((tmp8 & mask) != mask)
 			legacy_mode = 1;
-#if defined(CONFIG_NO_ATA_LEGACY)
-		/* Some platforms with PCI limits cannot address compat
-		   port space. In that case we punt if their firmware has
-		   left a device in compatibility mode */
-		if (legacy_mode) {
-			printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
-			return -EOPNOTSUPP;
-		}
-#endif
 	}
 
 	if (!devres_open_group(dev, NULL, GFP_KERNEL))