Message ID | 20100121005849.1fa343a9@linux.lan.towertech.it |
---|---|
State | Superseded |
Headers | show |
On Thu, Jan 21, 2010 at 12:58:49AM +0100, Alessandro Zummo wrote: > Error handling code following a kzalloc should free the allocated data. > > The semantic match that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > [...] > Signed-off-by: Julia Lawall <julia@diku.dk> > Signed-off-by: Alessandro Zummo <a.zummo@towertech.it> > Cc: Daniel Mack <daniel@caiaq.de> Acked-by: Daniel Mack <daniel@caiaq.de> Thanks, Daniel > patch-name: 2-8-drivers-rtc-introduce-missing-kfree.patch > patch-rev1: 98f7995fc38b62a0e182f3232aeddba05e065dee > patch-rev2: 21f21ad391e7d62effad9d00153598c20ad89471 > --- > drivers/rtc/rtc-mxc.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c > index 6bd5072..2642e6b 100644 > --- a/drivers/rtc/rtc-mxc.c > +++ b/drivers/rtc/rtc-mxc.c > @@ -396,8 +396,10 @@ static int __init mxc_rtc_probe(struct platform_device *pdev) > pdata->ioaddr = ioremap(res->start, resource_size(res)); > > clk = clk_get(&pdev->dev, "ckil"); > - if (IS_ERR(clk)) > - return PTR_ERR(clk); > + if (IS_ERR(clk)) { > + ret = PTR_ERR(clk); > + goto exit_free_pdata; > + } > > rate = clk_get_rate(clk); > clk_put(clk); >
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c index 6bd5072..2642e6b 100644 --- a/drivers/rtc/rtc-mxc.c +++ b/drivers/rtc/rtc-mxc.c @@ -396,8 +396,10 @@ static int __init mxc_rtc_probe(struct platform_device *pdev) pdata->ioaddr = ioremap(res->start, resource_size(res)); clk = clk_get(&pdev->dev, "ckil"); - if (IS_ERR(clk)) - return PTR_ERR(clk); + if (IS_ERR(clk)) { + ret = PTR_ERR(clk); + goto exit_free_pdata; + } rate = clk_get_rate(clk); clk_put(clk);