From patchwork Wed Jan 20 21:16:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 43361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A58B5B7D43 for ; Thu, 21 Jan 2010 08:21:35 +1100 (EST) Received: from localhost ([127.0.0.1]:44164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXhxl-0006X1-Q9 for incoming@patchwork.ozlabs.org; Wed, 20 Jan 2010 16:19:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXhuv-0004h5-EK for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:16:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXhuq-0004aQ-Od for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:16:44 -0500 Received: from [199.232.76.173] (port=56220 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXhuq-0004aC-I9 for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:16:40 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:50332) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXhup-0003r8-1E for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:16:40 -0500 Received: from flocke.weilnetz.de (p54ADF4FC.dip.t-dialin.net [84.173.244.252]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0LvzLR-1NuYsT3jkz-018IJX; Wed, 20 Jan 2010 22:16:37 +0100 Received: from stefan by flocke.weilnetz.de with local (Exim 4.71) (envelope-from ) id 1NXhum-0005Pv-3h; Wed, 20 Jan 2010 22:16:36 +0100 From: Stefan Weil To: QEMU Developers Date: Wed, 20 Jan 2010 22:16:35 +0100 Message-Id: <1264022195-20779-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.6.5 X-Provags-ID: V01U2FsdGVkX18werAEm8tUIzDYzuKVyR7SevKLDSnXhB8vlXK LMX2E+fV/JxMeENOjw2Vz4yB+pzCdHEE3JGp6mGYGKRqhlhWtS fn3hrXwuD9gtsgL8+AwFqLAAYHIVF2u1Evc2AuplD1nfsFVZTx Hhw== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCH] Tell users about out-of-memory errors X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Aborting without an error message when memory is short is not helpful, so print the reason for the abort. Try qemu -m 1000000 to force an out-of-memory error. Signed-off-by: Stefan Weil --- osdep.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/osdep.c b/osdep.c index 1310684..5d4e810 100644 --- a/osdep.c +++ b/osdep.c @@ -52,6 +52,7 @@ static void *oom_check(void *ptr) { if (ptr == NULL) { + perror("qemu (memory allocation)"); abort(); } return ptr; @@ -91,8 +92,11 @@ void *qemu_memalign(size_t alignment, size_t size) int ret; void *ptr; ret = posix_memalign(&ptr, alignment, size); - if (ret != 0) + if (ret != 0) { + fprintf(stderr, "Failed to allocate %zu B: %s\n", + size, strerror(errno)); abort(); + } return ptr; #elif defined(CONFIG_BSD) return oom_check(valloc(size));