| Message ID | 1422385126-19523-2-git-send-email-contact@paulk.fr |
|---|---|
| State | Accepted |
| Delegated to: | Ian Campbell |
| Headers | show |
Hi, On 27-01-15 19:58, Paul Kocialkowski wrote: > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> Thanks, I've merged this with a number of changes: - Fixed op the CONFIG_VIDEO_LCD_MODE to also properly define left/right and top/bottom margins. See: http://linux-sunxi.org/LCD - Added a "CONFIG_FDTFILE="sun5i-a13-tzx-q8-713b7.dtb" line, so that when future upstream kernels get a dtb file for this board things will just work. When submitting a dts file upstream for this board please use the same name :) Talking about upstream dts files, it would be great if you could write one. Note that we've recently adapted a new style for upstream dts files, so it is best to use one of the recent added boards as example, e.g. : https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.20&id=19a08b6b3f782f577b4b0fef9b6e60beba66c2f3 Regards, Hans > --- > board/sunxi/Kconfig | 4 ++++ > board/sunxi/MAINTAINERS | 5 +++++ > board/sunxi/Makefile | 1 + > configs/TZX-Q8-713B7_defconfig | 15 +++++++++++++++ > 4 files changed, 25 insertions(+) > create mode 100644 configs/TZX-Q8-713B7_defconfig > > diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig > index 738b55e..5c78cdf 100644 > --- a/board/sunxi/Kconfig > +++ b/board/sunxi/Kconfig > @@ -147,6 +147,10 @@ config TARGET_R7DONGLE > bool "R7DONGLE" > depends on MACH_SUN5I > > +config TARGET_TZX_Q8_713B7 > + bool "TZX-Q8-713B7" > + depends on MACH_SUN5I > + > endchoice > > config SYS_BOARD > diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS > index 743e7f5..da5419c 100644 > --- a/board/sunxi/MAINTAINERS > +++ b/board/sunxi/MAINTAINERS > @@ -100,3 +100,8 @@ MELE M5 BOARD > M: Ian Campbell <ijc@hellion.org.uk> > S: Maintained > F: configs/Mele_M5_defconfig > + > +TZX-Q8-713B7 BOARD > +M: Paul Kocialkowski <contact@paulk.fr> > +S: Maintained > +F: configs/TZX-Q8-713B7_defconfig > diff --git a/board/sunxi/Makefile b/board/sunxi/Makefile > index 71edb83..b14a8b2 100644 > --- a/board/sunxi/Makefile > +++ b/board/sunxi/Makefile > @@ -20,3 +20,4 @@ obj-$(CONFIG_TARGET_A13_OLINUXINOM) += dram_a13_oli_micro.o > obj-$(CONFIG_TARGET_AUXTEK_T004) += dram_a10s_olinuxino_m.o > obj-$(CONFIG_TARGET_MK802_A10S) += dram_sun5i_auto.o > obj-$(CONFIG_TARGET_R7DONGLE) += dram_r7dongle.o > +obj-$(CONFIG_TARGET_TZX_Q8_713B7) += dram_sun5i_auto.o > diff --git a/configs/TZX-Q8-713B7_defconfig b/configs/TZX-Q8-713B7_defconfig > new file mode 100644 > index 0000000..8696bdf > --- /dev/null > +++ b/configs/TZX-Q8-713B7_defconfig > @@ -0,0 +1,15 @@ > +CONFIG_SPL=y > +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,AXP209_POWER" > +CONFIG_USB_MUSB_SUNXI=y > +CONFIG_USB0_VBUS_PIN="PG12" > +CONFIG_VIDEO_LCD_MODE="x:800,y:480,depth:24,pclk_khz:33000,sync:3,vmode:0" > +CONFIG_VIDEO_LCD_POWER="AXP0-0" > +CONFIG_VIDEO_LCD_BL_EN="AXP0-1" > +CONFIG_VIDEO_LCD_BL_PWM="PB2" > ++S:CONFIG_ARM=y > ++S:CONFIG_ARCH_SUNXI=y > ++S:CONFIG_MACH_SUN5I=y > ++S:CONFIG_TARGET_TZX_Q8_713B7=y > ++S:CONFIG_DRAM_CLK=408 > ++S:CONFIG_DRAM_ZQ=123 > ++S:CONFIG_DRAM_EMR1=4 >
> Thanks, I've merged this with a number of changes: > - Fixed op the CONFIG_VIDEO_LCD_MODE to also properly define left/right > and top/bottom margins. See: http://linux-sunxi.org/LCD Wow, that's great, this is exactly what I was looking for. I guess I hadn't been looking hard enough for it! > - Added a "CONFIG_FDTFILE="sun5i-a13-tzx-q8-713b7.dtb" line, so that when > future upstream kernels get a dtb file for this board things will just > work. When submitting a dts file upstream for this board please use > the same name :) I was a little unsure about adding it or not, thanks for taking the decision. I will certainly try to add mainline support for the tablet at some point in the future, even though I will be using it with sunxi-3.4 on Replicant in the near future. > Talking about upstream dts files, it would be great if you could write > one. Note that we've recently adapted a new style for upstream dts files, > so it is best to use one of the recent added boards as example, e.g. : > > https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.20&id=19a08b6b3f782f577b4b0fef9b6e60beba66c2f3 Thanks! > Regards, > > Hans > > > > --- > > board/sunxi/Kconfig | 4 ++++ > > board/sunxi/MAINTAINERS | 5 +++++ > > board/sunxi/Makefile | 1 + > > configs/TZX-Q8-713B7_defconfig | 15 +++++++++++++++ > > 4 files changed, 25 insertions(+) > > create mode 100644 configs/TZX-Q8-713B7_defconfig > > > > diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig > > index 738b55e..5c78cdf 100644 > > --- a/board/sunxi/Kconfig > > +++ b/board/sunxi/Kconfig > > @@ -147,6 +147,10 @@ config TARGET_R7DONGLE > > bool "R7DONGLE" > > depends on MACH_SUN5I > > > > +config TARGET_TZX_Q8_713B7 > > + bool "TZX-Q8-713B7" > > + depends on MACH_SUN5I > > + > > endchoice > > > > config SYS_BOARD > > diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS > > index 743e7f5..da5419c 100644 > > --- a/board/sunxi/MAINTAINERS > > +++ b/board/sunxi/MAINTAINERS > > @@ -100,3 +100,8 @@ MELE M5 BOARD > > M: Ian Campbell <ijc@hellion.org.uk> > > S: Maintained > > F: configs/Mele_M5_defconfig > > + > > +TZX-Q8-713B7 BOARD > > +M: Paul Kocialkowski <contact@paulk.fr> > > +S: Maintained > > +F: configs/TZX-Q8-713B7_defconfig > > diff --git a/board/sunxi/Makefile b/board/sunxi/Makefile > > index 71edb83..b14a8b2 100644 > > --- a/board/sunxi/Makefile > > +++ b/board/sunxi/Makefile > > @@ -20,3 +20,4 @@ obj-$(CONFIG_TARGET_A13_OLINUXINOM) += dram_a13_oli_micro.o > > obj-$(CONFIG_TARGET_AUXTEK_T004) += dram_a10s_olinuxino_m.o > > obj-$(CONFIG_TARGET_MK802_A10S) += dram_sun5i_auto.o > > obj-$(CONFIG_TARGET_R7DONGLE) += dram_r7dongle.o > > +obj-$(CONFIG_TARGET_TZX_Q8_713B7) += dram_sun5i_auto.o > > diff --git a/configs/TZX-Q8-713B7_defconfig b/configs/TZX-Q8-713B7_defconfig > > new file mode 100644 > > index 0000000..8696bdf > > --- /dev/null > > +++ b/configs/TZX-Q8-713B7_defconfig > > @@ -0,0 +1,15 @@ > > +CONFIG_SPL=y > > +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,AXP209_POWER" > > +CONFIG_USB_MUSB_SUNXI=y > > +CONFIG_USB0_VBUS_PIN="PG12" > > +CONFIG_VIDEO_LCD_MODE="x:800,y:480,depth:24,pclk_khz:33000,sync:3,vmode:0" > > +CONFIG_VIDEO_LCD_POWER="AXP0-0" > > +CONFIG_VIDEO_LCD_BL_EN="AXP0-1" > > +CONFIG_VIDEO_LCD_BL_PWM="PB2" > > ++S:CONFIG_ARM=y > > ++S:CONFIG_ARCH_SUNXI=y > > ++S:CONFIG_MACH_SUN5I=y > > ++S:CONFIG_TARGET_TZX_Q8_713B7=y > > ++S:CONFIG_DRAM_CLK=408 > > ++S:CONFIG_DRAM_ZQ=123 > > ++S:CONFIG_DRAM_EMR1=4 > >
diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index 738b55e..5c78cdf 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -147,6 +147,10 @@ config TARGET_R7DONGLE bool "R7DONGLE" depends on MACH_SUN5I +config TARGET_TZX_Q8_713B7 + bool "TZX-Q8-713B7" + depends on MACH_SUN5I + endchoice config SYS_BOARD diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS index 743e7f5..da5419c 100644 --- a/board/sunxi/MAINTAINERS +++ b/board/sunxi/MAINTAINERS @@ -100,3 +100,8 @@ MELE M5 BOARD M: Ian Campbell <ijc@hellion.org.uk> S: Maintained F: configs/Mele_M5_defconfig + +TZX-Q8-713B7 BOARD +M: Paul Kocialkowski <contact@paulk.fr> +S: Maintained +F: configs/TZX-Q8-713B7_defconfig diff --git a/board/sunxi/Makefile b/board/sunxi/Makefile index 71edb83..b14a8b2 100644 --- a/board/sunxi/Makefile +++ b/board/sunxi/Makefile @@ -20,3 +20,4 @@ obj-$(CONFIG_TARGET_A13_OLINUXINOM) += dram_a13_oli_micro.o obj-$(CONFIG_TARGET_AUXTEK_T004) += dram_a10s_olinuxino_m.o obj-$(CONFIG_TARGET_MK802_A10S) += dram_sun5i_auto.o obj-$(CONFIG_TARGET_R7DONGLE) += dram_r7dongle.o +obj-$(CONFIG_TARGET_TZX_Q8_713B7) += dram_sun5i_auto.o diff --git a/configs/TZX-Q8-713B7_defconfig b/configs/TZX-Q8-713B7_defconfig new file mode 100644 index 0000000..8696bdf --- /dev/null +++ b/configs/TZX-Q8-713B7_defconfig @@ -0,0 +1,15 @@ +CONFIG_SPL=y +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,AXP209_POWER" +CONFIG_USB_MUSB_SUNXI=y +CONFIG_USB0_VBUS_PIN="PG12" +CONFIG_VIDEO_LCD_MODE="x:800,y:480,depth:24,pclk_khz:33000,sync:3,vmode:0" +CONFIG_VIDEO_LCD_POWER="AXP0-0" +CONFIG_VIDEO_LCD_BL_EN="AXP0-1" +CONFIG_VIDEO_LCD_BL_PWM="PB2" ++S:CONFIG_ARM=y ++S:CONFIG_ARCH_SUNXI=y ++S:CONFIG_MACH_SUN5I=y ++S:CONFIG_TARGET_TZX_Q8_713B7=y ++S:CONFIG_DRAM_CLK=408 ++S:CONFIG_DRAM_ZQ=123 ++S:CONFIG_DRAM_EMR1=4
Signed-off-by: Paul Kocialkowski <contact@paulk.fr> --- board/sunxi/Kconfig | 4 ++++ board/sunxi/MAINTAINERS | 5 +++++ board/sunxi/Makefile | 1 + configs/TZX-Q8-713B7_defconfig | 15 +++++++++++++++ 4 files changed, 25 insertions(+) create mode 100644 configs/TZX-Q8-713B7_defconfig