Patchwork [14/17] check pipe() return value

login
register
mail settings
Submitter Juan Quintela
Date Jan. 20, 2010, 8:14 p.m.
Message ID <ac3a82db13f9cb459079d6756effc7e4f217da19.1264017981.git.quintela@redhat.com>
Download mbox | patch
Permalink /patch/43358/
State New
Headers show

Comments

Juan Quintela - Jan. 20, 2010, 8:14 p.m.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hw/xen_domainbuild.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

Patch

diff --git a/hw/xen_domainbuild.c b/hw/xen_domainbuild.c
index 20d731d..2f59856 100644
--- a/hw/xen_domainbuild.c
+++ b/hw/xen_domainbuild.c
@@ -156,15 +156,18 @@  quit:
     return;
 }

-static void xen_domain_watcher(void)
+static int xen_domain_watcher(void)
 {
     int qemu_running = 1;
     int fd[2], i, n, rc;
     char byte;

-    pipe(fd);
+    if (pipe(fd) != 0) {
+        qemu_log("%s: Huh? pipe error: %s\n", __FUNCTION__, strerror(errno));
+        return -1;
+    }
     if (fork() != 0)
-        return; /* not child */
+        return 0; /* not child */

     /* close all file handles, except stdio/out/err,
      * our watch pipe and the xen interface handle */
@@ -238,7 +241,9 @@  int xen_domain_build_pv(const char *kernel, const char *ramdisk,
     }
     qemu_log("xen: created domain %d\n", xen_domid);
     atexit(xen_domain_cleanup);
-    xen_domain_watcher();
+    if (xen_domain_watcher() == -1) {
+        goto err;
+    }

     xenstore_domain_init1(kernel, ramdisk, cmdline);