diff mbox

[1/2] ARM: zynq: Remove bogus value from 'bias-disable' property

Message ID 1422301796-22888-1-git-send-email-soren.brinkmann@xilinx.com
State New
Headers show

Commit Message

Soren Brinkmann Jan. 26, 2015, 7:49 p.m. UTC
In one pinctrl node, a 'bias-disable' property is erroneously assigned a
value.

Fixes: ARM: zynq: DT: Add pinctrl information
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
Feel free to squash this into the mentioned patch. I don't see it in any
stable branch yet.

	Sören
---
 arch/arm/boot/dts/zynq-zc702.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Färber Jan. 27, 2015, 12:38 a.m. UTC | #1
Am 26.01.2015 um 20:49 schrieb Soren Brinkmann:
> In one pinctrl node, a 'bias-disable' property is erroneously assigned a
> value.
> 
> Fixes: ARM: zynq: DT: Add pinctrl information
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas
Michal Simek Jan. 28, 2015, 2:21 p.m. UTC | #2
On 01/27/2015 01:38 AM, Andreas Färber wrote:
> Am 26.01.2015 um 20:49 schrieb Soren Brinkmann:
>> In one pinctrl node, a 'bias-disable' property is erroneously assigned a
>> value.
>>
>> Fixes: ARM: zynq: DT: Add pinctrl information
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Andreas
> 

Applied both.

Thanks,
Michal
Soren Brinkmann Jan. 28, 2015, 3:41 p.m. UTC | #3
On Wed, 2015-01-28 at 03:21PM +0100, Michal Simek wrote:
> On 01/27/2015 01:38 AM, Andreas Färber wrote:
> > Am 26.01.2015 um 20:49 schrieb Soren Brinkmann:
> >> In one pinctrl node, a 'bias-disable' property is erroneously assigned a
> >> value.
> >>
> >> Fixes: ARM: zynq: DT: Add pinctrl information
> >> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > 
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> > 
> > Andreas
> > 
> 
> Applied both.

Thanks. Given how the branch looks now, you could squash 'ARM: zynq: DT:
Remove bogus value from 'bias-disable' property' and 'ARM: zynq: DT: Add
pinctrl information to USB nodes' into 'ARM: zynq: DT: Add pinctrl
information'. Then we have it all in one patch and spare everybody the
intermittent, partly broken commits.

	Sören
Michal Simek Jan. 29, 2015, 2:35 p.m. UTC | #4
On 01/28/2015 04:41 PM, Sören Brinkmann wrote:
> On Wed, 2015-01-28 at 03:21PM +0100, Michal Simek wrote:
>> On 01/27/2015 01:38 AM, Andreas Färber wrote:
>>> Am 26.01.2015 um 20:49 schrieb Soren Brinkmann:
>>>> In one pinctrl node, a 'bias-disable' property is erroneously assigned a
>>>> value.
>>>>
>>>> Fixes: ARM: zynq: DT: Add pinctrl information
>>>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>>>
>>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>>
>>> Andreas
>>>
>>
>> Applied both.
> 
> Thanks. Given how the branch looks now, you could squash 'ARM: zynq: DT:
> Remove bogus value from 'bias-disable' property' and 'ARM: zynq: DT: Add
> pinctrl information to USB nodes' into 'ARM: zynq: DT: Add pinctrl
> information'. Then we have it all in one patch and spare everybody the
> intermittent, partly broken commits.

That's not a problem. I have sent pull request with current state.

Thanks,
Michal
diff mbox

Patch

diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
index 365bdd407eb4..4f8835be4874 100644
--- a/arch/arm/boot/dts/zynq-zc702.dts
+++ b/arch/arm/boot/dts/zynq-zc702.dts
@@ -309,7 +309,7 @@ 
 
 		conf-tx {
 			pins = "MIO48";
-			bias-disable = <0>;
+			bias-disable;
 		};
 	};
 };