| Message ID | 1422300260-5361-5-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Jan 26, 2015 at 8:24 PM, Bernd Kuhls <bernd.kuhls@t-online.de> wrote: > To be replaced with giflib. Can you respin this patch? It's important to deprecate libungif because it's incompatible with libgif so if both are installed, the headers get overwritten, right now we don't have build problems because we are lucky and they are overwritten in right order :) But using top-parallel make i get build failures because the order is changed. Example: BR2_TOOLCHAIN_EXTERNAL=y BR2_PACKAGE_FBV=y BR2_PACKAGE_LIBUNGIF=y The following command build fine: make clean libungif giflib fbv But fbv fail to build with the following command: make clean giflib libungif fbv > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/libungif/Config.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/libungif/Config.in b/package/libungif/Config.in > index e8c301c..012ef76 100644 > --- a/package/libungif/Config.in > +++ b/package/libungif/Config.in > @@ -1,5 +1,7 @@ > config BR2_PACKAGE_LIBUNGIF > bool "libungif" > + depends on !BR2_PACKAGE_GIFLIB > + depends on BR2_DEPRECATED_SINCE_2015_02 # giflib > help > libungif is a library for handling the uncompressed GIF image format. > > -- > 1.7.10.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Bernd Kuhls, On Mon, 26 Jan 2015 20:24:20 +0100, Bernd Kuhls wrote: > To be replaced with giflib. > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/libungif/Config.in | 2 ++ > 1 file changed, 2 insertions(+) I cannot apply this patch: Kodi is still selecting libungif currently. Can you resend an updated patch series that fixes Kodi before marking libungif as deprecated ? I'll mark this patch as Changes Requested in patchwork in the mean time. Thanks, Thomas
Hi, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 @public.gmane.org> wrote in news:20150404184613.448298e5@free-electrons.com: > I cannot apply this patch: Kodi is still selecting libungif currently. > > Can you resend an updated patch series that fixes Kodi before marking > libungif as deprecated ? Done: http://patchwork.ozlabs.org/patch/459483/ Shall I resend http://patchwork.ozlabs.org/patch/432990/ ? Regards, Bernd
diff --git a/package/libungif/Config.in b/package/libungif/Config.in index e8c301c..012ef76 100644 --- a/package/libungif/Config.in +++ b/package/libungif/Config.in @@ -1,5 +1,7 @@ config BR2_PACKAGE_LIBUNGIF bool "libungif" + depends on !BR2_PACKAGE_GIFLIB + depends on BR2_DEPRECATED_SINCE_2015_02 # giflib help libungif is a library for handling the uncompressed GIF image format.
To be replaced with giflib. Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/libungif/Config.in | 2 ++ 1 file changed, 2 insertions(+)