From patchwork Wed Jan 20 14:06:21 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: Stop using "which" in ./configure
Date: Wed, 20 Jan 2010 04:06:21 -0000
From: =?utf-8?q?Lo=C3=AFc_Minier_=3Clool=40dooz=2Eorg=3E?=
X-Patchwork-Id: 43294
Message-Id: <20100120140621.GA973@pig.zood.org>
To: qemu-devel@nongnu.org

On Wed, Jan 20, 2010, Loïc Minier wrote:
>  I'm attaching a new patch which changes the tests a bit; I would prefer
>  if someone with access to a Solaris build environment would do this
>  though.

 Sorry, there was a typo in the new patch, a test was reversed; updated
 patch attached.


diff --git a/configure b/configure
index 90b3c18..4d48341 100755
--- a/configure
+++ b/configure
@@ -799,21 +799,19 @@ fi
 # Solaris specific configure tool chain decisions
 #
 if test "$solaris" = "yes" ; then
-  solinst=`path_of $install`
-  if test -z "$solinst" ; then
+  if ! has $install; then
     echo "Solaris install program not found. Use --install=/usr/ucb/install or"
     echo "install fileutils from www.blastwave.org using pkg-get -i fileutils"
     echo "to get ginstall which is used by default (which lives in /opt/csw/bin)"
     exit 1
   fi
-  if test "$solinst" = "/usr/sbin/install" ; then
+  if "`path_of $install`" = "/usr/sbin/install" ; then
     echo "Error: Solaris /usr/sbin/install is not an appropriate install program."
     echo "try ginstall from the GNU fileutils available from www.blastwave.org"
     echo "using pkg-get -i fileutils, or use --install=/usr/ucb/install"
     exit 1
   fi
-  sol_ar=`path_of ar`
-  if test -z "$sol_ar" ; then
+  if ! has ar; then
     echo "Error: No path includes ar"
     if test -f /usr/ccs/bin/ar ; then
       echo "Add /usr/ccs/bin to your path and rerun configure"