[1/2] gpio: sysfs: fix memory leak in gpiod_export_link
diff mbox

Message ID 1422270166-17525-2-git-send-email-johan@kernel.org
State New
Headers show

Commit Message

Johan Hovold Jan. 26, 2015, 11:02 a.m. UTC
Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when creating a link.

Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
using sysfs links")
Cc: stable <stable@vger.kernel.org>	# v2.6.32
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/gpio/gpiolib-sysfs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Jan. 30, 2015, 9:29 a.m. UTC | #1
On Mon, Jan 26, 2015 at 12:02 PM, Johan Hovold <johan@kernel.org> wrote:

> Fix memory leak in the gpio sysfs interface due to failure to drop
> reference to device returned by class_find_device when creating a link.
>
> Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
> using sysfs links")
> Cc: stable <stable@vger.kernel.org>     # v2.6.32
> Signed-off-by: Johan Hovold <johan@kernel.org>

Patch applied.

Let's see if I get it into v3.19 properly...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index 14c4f94813eb..820b1e70ddfe 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -648,6 +648,7 @@  int gpiod_export_link(struct device *dev, const char *name,
 		if (tdev != NULL) {
 			status = sysfs_create_link(&dev->kobj, &tdev->kobj,
 						name);
+			put_device(tdev);
 		} else {
 			status = -ENODEV;
 		}