Message ID | 1422182363-10932-1-git-send-email-_govind@gmx.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Sun, 2015-01-25 at 16:09 +0530, Govindarajulu Varadarajan wrote: > With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi > repoll is done only when work_done == budget. When in busy_poll is we return 0 > in napi_poll. We should return budget. > > Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> > --- > v2: > Remove unnecessary change for work_done >= budget return value. > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c > index 1d1147c..e468ed3 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c > @@ -3175,7 +3175,7 @@ static int bnx2x_poll(struct napi_struct *napi, int budget) > } > #endif > if (!bnx2x_fp_lock_napi(fp)) > - return work_done; > + return budget; > > for_each_cos_in_tx_queue(fp, cos) > if (bnx2x_tx_queue_has_work(fp->txdata_ptr[cos])) Thanks ! Acked-by: Eric Dumazet <edumazet@google.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Govindarajulu Varadarajan <_govind@gmx.com> Date: Sun, 25 Jan 2015 16:09:23 +0530 > With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi > repoll is done only when work_done == budget. When in busy_poll is we return 0 > in napi_poll. We should return budget. > > Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 1d1147c..e468ed3 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -3175,7 +3175,7 @@ static int bnx2x_poll(struct napi_struct *napi, int budget) } #endif if (!bnx2x_fp_lock_napi(fp)) - return work_done; + return budget; for_each_cos_in_tx_queue(fp, cos) if (bnx2x_tx_queue_has_work(fp->txdata_ptr[cos]))
With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi repoll is done only when work_done == budget. When in busy_poll is we return 0 in napi_poll. We should return budget. Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> --- v2: Remove unnecessary change for work_done >= budget return value. drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)