[x86] Add march/mtune=knl

Message ID	54C37689.1020601@mentor.com
State	New
Headers	show Return-Path: <gcc-patches-return-390345-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=GRb7sRsWOyDyIRXC7 1MhShGC/zsVXD+taWjlwo8dECFAuB2LrBcKGM4KKuHdn3qFvW1qI7xeJQvhE/N1M uki38m3vwQuz+6VwbXX/TbBTWs2RKxUwFNScLdCbWzqmNc0nTCHHJCdNRI4TehPS N9VtyOtzMUYnMWYIKK3aLmjd90= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org Message-ID: <54C37689.1020601@mentor.com> Date: Sat, 24 Jan 2015 11:40:09 +0100 From: Tom de Vries <Tom_deVries@mentor.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Uros Bizjak <ubizjak@gmail.com>, Ilya Tocar <tocarip.intel@gmail.com> CC: GCC Patches <gcc-patches@gcc.gnu.org> Subject: Re: [PATCH x86] Add march/mtune=knl References: <20141210162047.GA128205@msticlxl7.ims.intel.com> <CAFULd4YUcmmkDJ2UxmYPwUQ=AOq9CNQ833b7YLjo+KfPxVw_8w@mail.gmail.com> In-Reply-To: <CAFULd4YUcmmkDJ2UxmYPwUQ=AOq9CNQ833b7YLjo+KfPxVw_8w@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------000406060707020300030600"

Message ID

54C37689.1020601@mentor.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender
	:message-id:date:from:mime-version:to:cc:subject:references
	:in-reply-to:content-type; q=dns; s=default; b=GRb7sRsWOyDyIRXC7
	1MhShGC/zsVXD+taWjlwo8dECFAuB2LrBcKGM4KKuHdn3qFvW1qI7xeJQvhE/N1M
	uki38m3vwQuz+6VwbXX/TbBTWs2RKxUwFNScLdCbWzqmNc0nTCHHJCdNRI4TehPS
	N9VtyOtzMUYnMWYIKK3aLmjd90=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
Message-ID: <54C37689.1020601@mentor.com>
Date: Sat, 24 Jan 2015 11:40:09 +0100
From: Tom de Vries <Tom_deVries@mentor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Uros Bizjak <ubizjak@gmail.com>, Ilya Tocar <tocarip.intel@gmail.com>
CC: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH x86] Add march/mtune=knl
References: <20141210162047.GA128205@msticlxl7.ims.intel.com>
	<CAFULd4YUcmmkDJ2UxmYPwUQ=AOq9CNQ833b7YLjo+KfPxVw_8w@mail.gmail.com>
In-Reply-To: <CAFULd4YUcmmkDJ2UxmYPwUQ=AOq9CNQ833b7YLjo+KfPxVw_8w@mail.gmail.com>
Content-Type: multipart/mixed;
	boundary="------------000406060707020300030600"

Commit Message

Tom de Vries Jan. 24, 2015, 10:40 a.m. UTC

On 10-12-14 17:35, Uros Bizjak wrote:
> On Wed, Dec 10, 2014 at 5:20 PM, Ilya Tocar <tocarip.intel@gmail.com> wrote:

>> gcc/testsuite/
>>          * gcc.target/i386/funcspec-5.c: Test avx512f and knl.
>

>> --- a/gcc/testsuite/gcc.target/i386/funcspec-5.c
>> +++ b/gcc/testsuite/gcc.target/i386/funcspec-5.c

>> +extern void test_avx512 (void)                 __attribute__((__target__("avx512")));

>> +extern void test_no_avx512 (void)              __attribute__((__target__("no-avx512")));

funcspec-5.c is currently failing (mentioned in PR64342) with:
...
Excess errors:
src/gcc/testsuite/gcc.target/i386/funcspec-5.c:27:1: error: 
attribute(target("avx512")) is unknown
src/gcc/testsuite/gcc.target/i386/funcspec-5.c:50:1: error: 
attribute(target("no-avx512")) is unknown
...

Given the used of avx512f in the ChangeLog entry, I assume avx512f was meant in 
the attributes instead of avx512?

Attached patch ok for stage4 trunk?

Thanks,
- Tom

Comments

Uros Bizjak Jan. 24, 2015, 10:48 a.m. UTC | #1

On Sat, Jan 24, 2015 at 11:40 AM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> On 10-12-14 17:35, Uros Bizjak wrote:
>>
>> On Wed, Dec 10, 2014 at 5:20 PM, Ilya Tocar <tocarip.intel@gmail.com>
>> wrote:
>
>
>>> gcc/testsuite/
>>>          * gcc.target/i386/funcspec-5.c: Test avx512f and knl.
>>
>>
>
>>> --- a/gcc/testsuite/gcc.target/i386/funcspec-5.c
>>> +++ b/gcc/testsuite/gcc.target/i386/funcspec-5.c
>
>
>>> +extern void test_avx512 (void)
>>> __attribute__((__target__("avx512")));
>
>
>>> +extern void test_no_avx512 (void)
>>> __attribute__((__target__("no-avx512")));
>
>
> funcspec-5.c is currently failing (mentioned in PR64342) with:
> ...
> Excess errors:
> src/gcc/testsuite/gcc.target/i386/funcspec-5.c:27:1: error:
> attribute(target("avx512")) is unknown
> src/gcc/testsuite/gcc.target/i386/funcspec-5.c:50:1: error:
> attribute(target("no-avx512")) is unknown
> ...
>
> Given the used of avx512f in the ChangeLog entry, I assume avx512f was meant
> in the attributes instead of avx512?
>
> Attached patch ok for stage4 trunk?

OK.

Thanks,
Uros.

2015-01-24  Tom de Vries  <tom@codesourcery.com>

	* gcc.target/i386/funcspec-5.c: Replace avx512 with avx512f.
---
 gcc/testsuite/gcc.target/i386/funcspec-5.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.target/i386/funcspec-5.c b/gcc/testsuite/gcc.target/i386/funcspec-5.c
index 269e610..d796484 100644
--- a/gcc/testsuite/gcc.target/i386/funcspec-5.c
+++ b/gcc/testsuite/gcc.target/i386/funcspec-5.c
@@ -24,7 +24,7 @@  extern void test_ssse3 (void)			__attribute__((__target__("ssse3")));
 extern void test_tbm (void)			__attribute__((__target__("tbm")));
 extern void test_avx (void)			__attribute__((__target__("avx")));
 extern void test_avx2 (void)			__attribute__((__target__("avx2")));
-extern void test_avx512 (void)			__attribute__((__target__("avx512")));
+extern void test_avx512f (void)			__attribute__((__target__("avx512f")));
 
 extern void test_no_abm (void)			__attribute__((__target__("no-abm")));
 extern void test_no_aes (void)			__attribute__((__target__("no-aes")));
@@ -47,7 +47,7 @@  extern void test_no_ssse3 (void)		__attribute__((__target__("no-ssse3")));
 extern void test_no_tbm (void)			__attribute__((__target__("no-tbm")));
 extern void test_no_avx (void)			__attribute__((__target__("no-avx")));
 extern void test_no_avx2 (void)   		__attribute__((__target__("no-avx2")));
-extern void test_no_avx512 (void)   		__attribute__((__target__("no-avx512")));
+extern void test_no_avx512f (void)   		__attribute__((__target__("no-avx512f")));
 
 extern void test_arch_i386 (void)		__attribute__((__target__("arch=i386")));
 extern void test_arch_i486 (void)		__attribute__((__target__("arch=i486")));
-- 
1.9.1