Message ID | 1421994515-3070-5-git-send-email-jack.yoo@skyworksinc.com |
---|---|
State | Superseded, archived |
Headers | show |
On Fri, Jan 23, 2015 at 03:28:33PM +0900, gyungoh@gmail.com wrote: > From: Gyungoh Yoo <jack.yoo@skyworksinc.com> > > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com> > Acked-by: Bryan Wu <cooloney@gmail.com> The existing Ack is only for backlight driver. DT Ack please. > --- > Changes v10: > Nothing > > Changes v9: > Nothing > > Changes v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable property to generic property for GPIO > Made up the example for backlight DT > > Changes v7: > Nothing > > Changes v6: > Nothing > > Changes v5: > Nothing > > Changes v4: > Nothing > > Changes v3: > Nothing > > Changes v2: > Added reg attribute for I2C slave address > > .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > new file mode 100644 > index 0000000..8daebf5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > @@ -0,0 +1,29 @@ > +SKY81452-backlight bindings > + > +Required properties: > +- compatible : Must be "skyworks,sky81452-backlight" > + > +Optional properties: > +- name : Name of backlight device. Default is 'lcd-backlight'. > +- gpios : GPIO to use to EN pin. > + See Documentation/devicetree/bindings/gpio/gpio.txt > +- skyworks,en-channels : Enable mask for current sink channel 1 to 6. > +- skyworks,ignore-pwm : Ignore both PWM input > +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. > +- skyworks,phase-shift : Enable phase shift mode > +- skyworks,ovp-level : Over-voltage protection level. > + Should be between 14 or 28V. > +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V. > +- skyworks,current-limit : It should be 2300mA or 2750mA. > + > +Example: > + > + backlight { > + compatible = "skyworks,sky81452-backlight"; > + name = "pwm-backlight"; > + skyworks,en-channels = <0x3f>; > + skyworks,ignore-pwm; > + skyworks,phase-shift; > + skyworks,ovp-level = <20>; > + skyworks,current-limit = <2300>; > + }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 23, 2015 at 12:28 AM, <gyungoh@gmail.com> wrote: > From: Gyungoh Yoo <jack.yoo@skyworksinc.com> > > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com> > Acked-by: Bryan Wu <cooloney@gmail.com> > --- > Changes v10: > Nothing > > Changes v9: > Nothing > > Changes v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable property to generic property for GPIO > Made up the example for backlight DT > > Changes v7: > Nothing > > Changes v6: > Nothing > > Changes v5: > Nothing > > Changes v4: > Nothing > > Changes v3: > Nothing > > Changes v2: > Added reg attribute for I2C slave address You did? Where is it? > .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > new file mode 100644 > index 0000000..8daebf5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > @@ -0,0 +1,29 @@ > +SKY81452-backlight bindings > + > +Required properties: > +- compatible : Must be "skyworks,sky81452-backlight" > + > +Optional properties: > +- name : Name of backlight device. Default is 'lcd-backlight'. > +- gpios : GPIO to use to EN pin. > + See Documentation/devicetree/bindings/gpio/gpio.txt > +- skyworks,en-channels : Enable mask for current sink channel 1 to 6. Does led-sources property being added in 3.20 work for this? > +- skyworks,ignore-pwm : Ignore both PWM input > +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. > +- skyworks,phase-shift : Enable phase shift mode > +- skyworks,ovp-level : Over-voltage protection level. > + Should be between 14 or 28V. Please append units (-volt) > +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V. Please append units (-volt) > +- skyworks,current-limit : It should be 2300mA or 2750mA. Please append units (-mA) > + > +Example: > + > + backlight { > + compatible = "skyworks,sky81452-backlight"; > + name = "pwm-backlight"; > + skyworks,en-channels = <0x3f>; > + skyworks,ignore-pwm; > + skyworks,phase-shift; > + skyworks,ovp-level = <20>; > + skyworks,current-limit = <2300>; > + }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 04, 2015 at 09:11:22AM -0600, Rob Herring wrote: > On Fri, Jan 23, 2015 at 12:28 AM, <gyungoh@gmail.com> wrote: > > From: Gyungoh Yoo <jack.yoo@skyworksinc.com> > > > > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com> > > Acked-by: Bryan Wu <cooloney@gmail.com> > > --- > > Changes v10: > > Nothing > > > > Changes v9: > > Nothing > > > > Changes v8: > > Renamed property names for backlight with vendor prefix > > Modified gpio-enable property to generic property for GPIO > > Made up the example for backlight DT > > > > Changes v7: > > Nothing > > > > Changes v6: > > Nothing > > > > Changes v5: > > Nothing > > > > Changes v4: > > Nothing > > > > Changes v3: > > Nothing > > > > Changes v2: > > Added reg attribute for I2C slave address > > You did? Where is it? It was just changes on version 2. Since that version, the patch series was separted. > > > .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > > > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > new file mode 100644 > > index 0000000..8daebf5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > @@ -0,0 +1,29 @@ > > +SKY81452-backlight bindings > > + > > +Required properties: > > +- compatible : Must be "skyworks,sky81452-backlight" > > + > > +Optional properties: > > +- name : Name of backlight device. Default is 'lcd-backlight'. > > +- gpios : GPIO to use to EN pin. > > + See Documentation/devicetree/bindings/gpio/gpio.txt > > +- skyworks,en-channels : Enable mask for current sink channel 1 to 6. > > Does led-sources property being added in 3.20 work for this? I think so. I will modify it. > > > +- skyworks,ignore-pwm : Ignore both PWM input > > +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. > > +- skyworks,phase-shift : Enable phase shift mode > > +- skyworks,ovp-level : Over-voltage protection level. > > + Should be between 14 or 28V. > > Please append units (-volt) I will append it and resubmit the patch. Thanks. > > > +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V. > > Please append units (-volt) > > > +- skyworks,current-limit : It should be 2300mA or 2750mA. > > Please append units (-mA) > > > + > > +Example: > > + > > + backlight { > > + compatible = "skyworks,sky81452-backlight"; > > + name = "pwm-backlight"; > > + skyworks,en-channels = <0x3f>; > > + skyworks,ignore-pwm; > > + skyworks,phase-shift; > > + skyworks,ovp-level = <20>; > > + skyworks,current-limit = <2300>; > > + }; > > -- > > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt new file mode 100644 index 0000000..8daebf5 --- /dev/null +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt @@ -0,0 +1,29 @@ +SKY81452-backlight bindings + +Required properties: +- compatible : Must be "skyworks,sky81452-backlight" + +Optional properties: +- name : Name of backlight device. Default is 'lcd-backlight'. +- gpios : GPIO to use to EN pin. + See Documentation/devicetree/bindings/gpio/gpio.txt +- skyworks,en-channels : Enable mask for current sink channel 1 to 6. +- skyworks,ignore-pwm : Ignore both PWM input +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. +- skyworks,phase-shift : Enable phase shift mode +- skyworks,ovp-level : Over-voltage protection level. + Should be between 14 or 28V. +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V. +- skyworks,current-limit : It should be 2300mA or 2750mA. + +Example: + + backlight { + compatible = "skyworks,sky81452-backlight"; + name = "pwm-backlight"; + skyworks,en-channels = <0x3f>; + skyworks,ignore-pwm; + skyworks,phase-shift; + skyworks,ovp-level = <20>; + skyworks,current-limit = <2300>; + };