| Message ID | 20100119151450.GA8250@serverengines.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sarveshwar Bandi <sarveshwarb@serverengines.com> Date: Tue, 19 Jan 2010 20:45:00 +0530 > The ddr dma ethtool self test needs to be performed even when ETH_TEST_FL_OFFLINE is not set. > > Signed-off-by: Sarveshwar Bandi <sarveshwarb@serverengines.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c index f18c02f..2f2ebbd 100644 --- a/drivers/net/benet/be_ethtool.c +++ b/drivers/net/benet/be_ethtool.c @@ -545,10 +545,11 @@ be_self_test(struct net_device *netdev, &data[2]) != 0) { test->flags |= ETH_TEST_FL_FAILED; } + } - data[3] = be_test_ddr_dma(adapter); - if (data[3] != 0) - test->flags |= ETH_TEST_FL_FAILED; + if (be_test_ddr_dma(adapter) != 0) { + data[3] = 1; + test->flags |= ETH_TEST_FL_FAILED; } }
The ddr dma ethtool self test needs to be performed even when ETH_TEST_FL_OFFLINE is not set. Signed-off-by: Sarveshwar Bandi <sarveshwarb@serverengines.com> --- drivers/net/benet/be_ethtool.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)