diff mbox

[05/15] memory: remove assertion on memory_region_destroy

Message ID 1421938053-10318-6-git-send-email-pbonzini@redhat.com
State New
Headers show

Commit Message

Paolo Bonzini Jan. 22, 2015, 2:47 p.m. UTC 
From: Jan Kiszka <jan.kiszka@siemens.com>

Now that memory_region_destroy can be called from an RCU callback,
checking the BQL-protected global memory_region_transaction_depth
does not make much sense.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 memory.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Fam Zheng Jan. 26, 2015, 6:04 a.m. UTC | #1 
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Now that memory_region_destroy can be called from an RCU callback,
> checking the BQL-protected global memory_region_transaction_depth
> does not make much sense.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  memory.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/memory.c b/memory.c
> index c343bf3..8c3d8c0 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1263,7 +1263,6 @@ static void memory_region_finalize(Object *obj)
>      MemoryRegion *mr = MEMORY_REGION(obj);
>  
>      assert(QTAILQ_EMPTY(&mr->subregions));
> -    assert(memory_region_transaction_depth == 0);
>      mr->destructor(mr);
>      memory_region_clear_coalescing(mr);
>      g_free((char *)mr->name);
> -- 
> 1.8.3.1
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>
diff mbox

Patch

diff --git a/memory.c b/memory.c
index c343bf3..8c3d8c0 100644
--- a/memory.c
+++ b/memory.c
@@ -1263,7 +1263,6 @@  static void memory_region_finalize(Object *obj)
     MemoryRegion *mr = MEMORY_REGION(obj);
 
     assert(QTAILQ_EMPTY(&mr->subregions));
-    assert(memory_region_transaction_depth == 0);
     mr->destructor(mr);
     memory_region_clear_coalescing(mr);
     g_free((char *)mr->name);