Message ID | 1421925068-11787-1-git-send-email-ijc+uboot@hellion.org.uk |
---|---|
State | Superseded |
Headers | show |
Hi, On 22-01-15 12:11, Ian Campbell wrote: > From: Ian Campbell <ijc@hellion.org.uk> > > HDMI, USB and Ethernet appear functional, I've not done extensive tests of all > peripherals though. > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk> > --- > Hans, dunno if you have one of these, am happy to move to the common bit of > MAINTAINERS if you do. > > Applies on "sunxi: Convert sun7i boards to use auto dram configuration" Yes making it a nice and simple patch touching only 2 files, which is one of then reasons why I want to move everything over to doing dram autoconf, as it makes adding new boards easier. As for me having one of these, no I do not have one of these, I have an M3 which uses an emmc instead of nand (which is nice as we support that), has its vga connector populated, which for some reason the M5 does not have, even though there is room in the case for one (the A10 version had VGA) and which does not have its sata connector populated (not so nice). Talking about the sata connector, why have you not enabled it / AHCI support ? AFAICT the M5 has it populated. Other then that this looks good. If you can do a new version with AHCI support (unless there is a reason to omit it) then I'll queue it up in next. Regards, Hans > --- > board/sunxi/MAINTAINERS | 5 +++++ > configs/Mele_M5_defconfig | 13 +++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 configs/Mele_M5_defconfig > > diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS > index cc04e6c..fea23b8 100644 > --- a/board/sunxi/MAINTAINERS > +++ b/board/sunxi/MAINTAINERS > @@ -93,3 +93,8 @@ MARSBOARD-A10 BOARD > M: Aleksei Mamlin <mamlinav@gmail.com> > S: Maintained > F: configs/Marsboard_A10_defconfig > + > +MELE M5 BOARD > +M: Ian Campbell <ijc@hellion.org.uk> > +S: Maintained > +F: configs/Mele_M5_defconfig > diff --git a/configs/Mele_M5_defconfig b/configs/Mele_M5_defconfig > new file mode 100644 > index 0000000..2165987 > --- /dev/null > +++ b/configs/Mele_M5_defconfig > @@ -0,0 +1,13 @@ > +CONFIG_SPL=y > +CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,USB_EHCI,STATUSLED=234" > +CONFIG_FDTFILE="sun7i-a20-m5.dtb" > +CONFIG_VIDEO_HDMI=y > ++S:CONFIG_MMC0_CD_PIN="PH1" > ++S:CONFIG_USB1_VBUS_PIN="PH6" > ++S:CONFIG_USB2_VBUS_PIN="PH3" > ++S:CONFIG_ARM=y > ++S:CONFIG_ARCH_SUNXI=y > ++S:CONFIG_MACH_SUN7I=y > ++S:CONFIG_DRAM_CLK=432 > ++S:CONFIG_DRAM_ZQ=122 > ++S:CONFIG_DRAM_EMR1=4 >
On Thu, 2015-01-22 at 12:28 +0100, Hans de Goede wrote: > Hi, > > On 22-01-15 12:11, Ian Campbell wrote: > > From: Ian Campbell <ijc@hellion.org.uk> > > > > HDMI, USB and Ethernet appear functional, I've not done extensive tests of all > > peripherals though. > > > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk> > > --- > > Hans, dunno if you have one of these, am happy to move to the common bit of > > MAINTAINERS if you do. > > > > Applies on "sunxi: Convert sun7i boards to use auto dram configuration" > > Yes making it a nice and simple patch touching only 2 files, which is one > of then reasons why I want to move everything over to doing dram autoconf, > as it makes adding new boards easier. Absolutely, I'm now completely convinced ;-) > As for me having one of these, no I do not have one of these, I have an > M3 which uses an emmc instead of nand (which is nice as we support that), > has its vga connector populated, which for some reason the M5 does not have, > even though there is room in the case for one (the A10 version had VGA) > and which does not have its sata connector populated (not so nice). > > Talking about the sata connector, why have you not enabled it / AHCI > support ? AFAICT the M5 has it populated. Other then that this looks good. > If you can do a new version with AHCI support (unless there is a reason > to omit it) then I'll queue it up in next. I forgot, mainly because I was too lazy to go and find a HDD yet so it wasn't sticking out the top as a big red flag... I'll respin, although perhaps not today/ Ian.
diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS index cc04e6c..fea23b8 100644 --- a/board/sunxi/MAINTAINERS +++ b/board/sunxi/MAINTAINERS @@ -93,3 +93,8 @@ MARSBOARD-A10 BOARD M: Aleksei Mamlin <mamlinav@gmail.com> S: Maintained F: configs/Marsboard_A10_defconfig + +MELE M5 BOARD +M: Ian Campbell <ijc@hellion.org.uk> +S: Maintained +F: configs/Mele_M5_defconfig diff --git a/configs/Mele_M5_defconfig b/configs/Mele_M5_defconfig new file mode 100644 index 0000000..2165987 --- /dev/null +++ b/configs/Mele_M5_defconfig @@ -0,0 +1,13 @@ +CONFIG_SPL=y +CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,USB_EHCI,STATUSLED=234" +CONFIG_FDTFILE="sun7i-a20-m5.dtb" +CONFIG_VIDEO_HDMI=y ++S:CONFIG_MMC0_CD_PIN="PH1" ++S:CONFIG_USB1_VBUS_PIN="PH6" ++S:CONFIG_USB2_VBUS_PIN="PH3" ++S:CONFIG_ARM=y ++S:CONFIG_ARCH_SUNXI=y ++S:CONFIG_MACH_SUN7I=y ++S:CONFIG_DRAM_CLK=432 ++S:CONFIG_DRAM_ZQ=122 ++S:CONFIG_DRAM_EMR1=4