diff mbox

sparse: Fix build with sparse on .S files

Message ID 1421920426-16878-1-git-send-email-borntraeger@de.ibm.com
State New
Headers show

Commit Message

Christian Borntraeger Jan. 22, 2015, 9:53 a.m. UTC
rules.mak has a rule for .S files using CPP. This will result in
errors like
  CPP   s390-ccw/start.asm
 cc: error: unrecognized command line option '-Wbitwise'

Lets also redefine CPP in case of --enable-sparse.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 configure | 1 +
 1 file changed, 1 insertion(+)

Comments

Paolo Bonzini Jan. 22, 2015, 1:58 p.m. UTC | #1
On 22/01/2015 10:53, Christian Borntraeger wrote:
> rules.mak has a rule for .S files using CPP. This will result in
> errors like
>   CPP   s390-ccw/start.asm
>  cc: error: unrecognized command line option '-Wbitwise'
> 
> Lets also redefine CPP in case of --enable-sparse.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 47048f0..3bdda2e 100755
> --- a/configure
> +++ b/configure
> @@ -4909,6 +4909,7 @@ echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
>  echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
>  if test "$sparse" = "yes" ; then
>    echo "CC           := REAL_CC=\"\$(CC)\" cgcc"       >> $config_host_mak
> +  echo "CPP          := REAL_CC=\"\$(CPP)\" cgcc"      >> $config_host_mak
>    echo "CXX          := REAL_CC=\"\$(CXX)\" cgcc"      >> $config_host_mak
>    echo "HOST_CC      := REAL_CC=\"\$(HOST_CC)\" cgcc"  >> $config_host_mak
>    echo "QEMU_CFLAGS  += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak
> 

Queued, thanks.

Paolo
diff mbox

Patch

diff --git a/configure b/configure
index 47048f0..3bdda2e 100755
--- a/configure
+++ b/configure
@@ -4909,6 +4909,7 @@  echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
 echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
 if test "$sparse" = "yes" ; then
   echo "CC           := REAL_CC=\"\$(CC)\" cgcc"       >> $config_host_mak
+  echo "CPP          := REAL_CC=\"\$(CPP)\" cgcc"      >> $config_host_mak
   echo "CXX          := REAL_CC=\"\$(CXX)\" cgcc"      >> $config_host_mak
   echo "HOST_CC      := REAL_CC=\"\$(HOST_CC)\" cgcc"  >> $config_host_mak
   echo "QEMU_CFLAGS  += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak