| Message ID | 1421899601-19327-3-git-send-email-beomho.seo@samsung.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, 22 Jan 2015, Beomho Seo wrote: > This patch device tree binding documentation for rt5033 multifunction device. > > Cc: Sebastian Reichel <sre@kernel.org> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Ian campbell <ijc+devicetree@hellion.org.uk> > Cc: Kumar Gala <galak@codeaurora.org> > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Lee Jones <lee.jones@linaro.org> I did not Ack this patch. Your new vendor bindings require a DT Ack. Although, as the ones I'm concerned with are Regulator related, and Ack from Mark Brown will also suffice. > --- > Changes in v4 > - none. > Changes in v3 > - Add Acked-by > Changes in v2 > - Fix incorrect typo. > - Align -uamp and -uvolt names with regulator binding suffixes. > - Drop incorrect phandle. > - Fix incorrect example. > --- > > Documentation/devicetree/bindings/mfd/rt5033.txt | 101 ++++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 2 files changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/rt5033.txt > > diff --git a/Documentation/devicetree/bindings/mfd/rt5033.txt b/Documentation/devicetree/bindings/mfd/rt5033.txt > new file mode 100644 > index 0000000..64b23e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/rt5033.txt > @@ -0,0 +1,101 @@ > +Richtek RT5033 Power management Integrated Circuit > + > +RT5033 is a Multifunction device which includes battery charger, fuel gauge, > +flash LED current source, LDO and synchronous Buck converter for portable > +applications. It is interfaced to host controller using i2c interface. > + > +Required properties: > +- compatible : Must be "richtek,rt5033" > +- reg : Specifies the i2c slave address of general part. > +- interrupts : This i2c devices has an IRQ line connected to the main SoC. > +- interrupt-parent : The parent interrupt controller. > + > +Optional node: > +Regulators: The regulators of RT5033 have to be instantiated under sub-node > +named "regulators" using the following format. > + > + regulators { > + regulator-name { > + regulator-name = LDO/BUCK > + regulator subnodes called X, Y and Z > + }; > + }; > + refer Documentation/devicetree/bindings/regulator/regulator.txt > + > + > +Battery charger: There battery charger of RT5033 have to be instantiated under > +sub-node named "charger" using the following format. > + > +Required properties: > +- compatible : Must be "richtek,rt5033-charger". > +- richtek,pre-uamp : Current of pre-charge mode. The pre-charge current levels > + are 350 mA to 650 mA programmed by I2C per 100 mA. > +- richtek,fast-uamp : Current of fast-charge mode. The fast-charge current > + levels are 700 mA to 2000 mA programmed by I2C per 100 mA. > +- richtek,eoc-uamp : This property is end of charge current. Its level 150 mA > + to 200 mA. > +- richtek,pre-threshold-uvolt : Voltage of threshold pre-charge mode. Battery > + voltage is below pre-charge threshold voltage, the charger is in pre-charge > + mode with pre-charge current. Its levels are 2.3 V to 3.8 V programmed > + by I2C per 0.1 V. > +- richtek,const-uvolt : Battery regulation voltage of constant voltage mode. > + This voltage level 3.65 V to 4.4 V bye I2C per 0.025 V. > + > + charger { > + compatible = "richtek,rt5033-charger"; > + richtek,pre-uamp = <350000>; > + richtek,fast-uamp = <2000000>; > + richtek,eoc-uamp = <250000>; > + richtek,pre-threshold-uvolt = <3400000>; > + richtek,const-uvolt = <4350000>; > + > + }; > + > + > +Fuelgauge: There fuelgauge of RT5033 to be instantiated node named "fuelgauge" > +using the following format. > + > +Required properties: > +- compatible = Must be "richtek,rt5033-battery". > + > + rt5033@35 { > + compatible = "richtek,rt5033-battery"; > + interrupt-parent = <&gpx2>; > + interrupts = <3 0>; > + reg = <0x35>; > + }; > + > +Example: > + > + rt5033@34 { > + compatible = "richtek,rt5033"; > + reg = <0x34>; > + interrupt-parent = <&gpx1>; > + interrupts = <5 0>; > + > + regulators { > + buck_reg: BUCK { > + regulator-name = "BUCK"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + }; > + }; > + > + charger { > + compatible = "richtek,rt5033-charger"; > + richtek,pre-uamp = <350000>; > + richtek,fast-uamp = <2000000>; > + richtek,eoc-uamp = <250000>; > + richtek,pre-threshold-uvolt = <3400000>; > + richtek,const-uvolt = <4350000>; > + }; > + > + }; > + > + rt5033@35 { > + compatible = "richtek,rt5033-battery"; > + interrupt-parent = <&gpx2>; > + interrupts = <3 0>; > + reg = <0x35>; > + }; > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index b1df0ad..b6a2ca1 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -134,6 +134,7 @@ ralink Mediatek/Ralink Technology Corp. > ramtron Ramtron International > realtek Realtek Semiconductor Corp. > renesas Renesas Electronics Corporation > +richtek Richtek Technology Corporation > ricoh Ricoh Co. Ltd. > rockchip Fuzhou Rockchip Electronics Co., Ltd > samsung Samsung Semiconductor
On 01/22/2015 04:41 PM, Lee Jones wrote: > On Thu, 22 Jan 2015, Beomho Seo wrote: > >> This patch device tree binding documentation for rt5033 multifunction device. >> >> Cc: Sebastian Reichel <sre@kernel.org> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: Mark Brown <broonie@kernel.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Pawel Moll <pawel.moll@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Ian campbell <ijc+devicetree@hellion.org.uk> >> Cc: Kumar Gala <galak@codeaurora.org> >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> >> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Lee Jones <lee.jones@linaro.org> > > I did not Ack this patch. > > Your new vendor bindings require a DT Ack. > > Although, as the ones I'm concerned with are Regulator related, and > Ack from Mark Brown will also suffice. > I want to apologize for my mistake. I completely misunderstood your reply. Unfortunately, This patch merged by Sebastian at his git. Please tell me what to do. >> --- >> Changes in v4 >> - none. >> Changes in v3 >> - Add Acked-by >> Changes in v2 >> - Fix incorrect typo. >> - Align -uamp and -uvolt names with regulator binding suffixes. >> - Drop incorrect phandle. >> - Fix incorrect example. >> --- >> >> Documentation/devicetree/bindings/mfd/rt5033.txt | 101 ++++++++++++++++++++ >> .../devicetree/bindings/vendor-prefixes.txt | 1 + >> 2 files changed, 102 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/rt5033.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/rt5033.txt b/Documentation/devicetree/bindings/mfd/rt5033.txt >> new file mode 100644 >> index 0000000..64b23e8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/rt5033.txt >> @@ -0,0 +1,101 @@ >> +Richtek RT5033 Power management Integrated Circuit >> + >> +RT5033 is a Multifunction device which includes battery charger, fuel gauge, >> +flash LED current source, LDO and synchronous Buck converter for portable >> +applications. It is interfaced to host controller using i2c interface. >> + >> +Required properties: >> +- compatible : Must be "richtek,rt5033" >> +- reg : Specifies the i2c slave address of general part. >> +- interrupts : This i2c devices has an IRQ line connected to the main SoC. >> +- interrupt-parent : The parent interrupt controller. >> + >> +Optional node: >> +Regulators: The regulators of RT5033 have to be instantiated under sub-node >> +named "regulators" using the following format. >> + >> + regulators { >> + regulator-name { >> + regulator-name = LDO/BUCK >> + regulator subnodes called X, Y and Z >> + }; >> + }; >> + refer Documentation/devicetree/bindings/regulator/regulator.txt >> + >> + >> +Battery charger: There battery charger of RT5033 have to be instantiated under >> +sub-node named "charger" using the following format. >> + >> +Required properties: >> +- compatible : Must be "richtek,rt5033-charger". >> +- richtek,pre-uamp : Current of pre-charge mode. The pre-charge current levels >> + are 350 mA to 650 mA programmed by I2C per 100 mA. >> +- richtek,fast-uamp : Current of fast-charge mode. The fast-charge current >> + levels are 700 mA to 2000 mA programmed by I2C per 100 mA. >> +- richtek,eoc-uamp : This property is end of charge current. Its level 150 mA >> + to 200 mA. >> +- richtek,pre-threshold-uvolt : Voltage of threshold pre-charge mode. Battery >> + voltage is below pre-charge threshold voltage, the charger is in pre-charge >> + mode with pre-charge current. Its levels are 2.3 V to 3.8 V programmed >> + by I2C per 0.1 V. >> +- richtek,const-uvolt : Battery regulation voltage of constant voltage mode. >> + This voltage level 3.65 V to 4.4 V bye I2C per 0.025 V. >> + >> + charger { >> + compatible = "richtek,rt5033-charger"; >> + richtek,pre-uamp = <350000>; >> + richtek,fast-uamp = <2000000>; >> + richtek,eoc-uamp = <250000>; >> + richtek,pre-threshold-uvolt = <3400000>; >> + richtek,const-uvolt = <4350000>; >> + >> + }; >> + >> + >> +Fuelgauge: There fuelgauge of RT5033 to be instantiated node named "fuelgauge" >> +using the following format. >> + >> +Required properties: >> +- compatible = Must be "richtek,rt5033-battery". >> + >> + rt5033@35 { >> + compatible = "richtek,rt5033-battery"; >> + interrupt-parent = <&gpx2>; >> + interrupts = <3 0>; >> + reg = <0x35>; >> + }; >> + >> +Example: >> + >> + rt5033@34 { >> + compatible = "richtek,rt5033"; >> + reg = <0x34>; >> + interrupt-parent = <&gpx1>; >> + interrupts = <5 0>; >> + >> + regulators { >> + buck_reg: BUCK { >> + regulator-name = "BUCK"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + }; >> + }; >> + >> + charger { >> + compatible = "richtek,rt5033-charger"; >> + richtek,pre-uamp = <350000>; >> + richtek,fast-uamp = <2000000>; >> + richtek,eoc-uamp = <250000>; >> + richtek,pre-threshold-uvolt = <3400000>; >> + richtek,const-uvolt = <4350000>; >> + }; >> + >> + }; >> + >> + rt5033@35 { >> + compatible = "richtek,rt5033-battery"; >> + interrupt-parent = <&gpx2>; >> + interrupts = <3 0>; >> + reg = <0x35>; >> + }; >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt >> index b1df0ad..b6a2ca1 100644 >> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt >> @@ -134,6 +134,7 @@ ralink Mediatek/Ralink Technology Corp. >> ramtron Ramtron International >> realtek Realtek Semiconductor Corp. >> renesas Renesas Electronics Corporation >> +richtek Richtek Technology Corporation >> ricoh Ricoh Co. Ltd. >> rockchip Fuzhou Rockchip Electronics Co., Ltd >> samsung Samsung Semiconductor > Thanks, Beomho Seo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 22 Jan 2015, Beomho Seo wrote: > On 01/22/2015 04:41 PM, Lee Jones wrote: > > On Thu, 22 Jan 2015, Beomho Seo wrote: > > > >> This patch device tree binding documentation for rt5033 multifunction device. > >> > >> Cc: Sebastian Reichel <sre@kernel.org> > >> Cc: Lee Jones <lee.jones@linaro.org> > >> Cc: Mark Brown <broonie@kernel.org> > >> Cc: Rob Herring <robh+dt@kernel.org> > >> Cc: Pawel Moll <pawel.moll@arm.com> > >> Cc: Mark Rutland <mark.rutland@arm.com> > >> Cc: Ian campbell <ijc+devicetree@hellion.org.uk> > >> Cc: Kumar Gala <galak@codeaurora.org> > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > >> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Acked-by: Lee Jones <lee.jones@linaro.org> > > > > I did not Ack this patch. > > > > Your new vendor bindings require a DT Ack. > > > > Although, as the ones I'm concerned with are Regulator related, and > > Ack from Mark Brown will also suffice. > > > > I want to apologize for my mistake. I completely misunderstood your reply. > Unfortunately, This patch merged by Sebastian at his git. > Please tell me what to do. That's strange, as I haven't heard anything from Sebastian. Anyway, he needs to remove it from his tree until we receive a suitable Ack. > >> --- > >> Changes in v4 > >> - none. > >> Changes in v3 > >> - Add Acked-by > >> Changes in v2 > >> - Fix incorrect typo. > >> - Align -uamp and -uvolt names with regulator binding suffixes. > >> - Drop incorrect phandle. > >> - Fix incorrect example. > >> --- > >> > >> Documentation/devicetree/bindings/mfd/rt5033.txt | 101 ++++++++++++++++++++ > >> .../devicetree/bindings/vendor-prefixes.txt | 1 + > >> 2 files changed, 102 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/rt5033.txt > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/rt5033.txt b/Documentation/devicetree/bindings/mfd/rt5033.txt > >> new file mode 100644 > >> index 0000000..64b23e8 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/rt5033.txt > >> @@ -0,0 +1,101 @@ > >> +Richtek RT5033 Power management Integrated Circuit > >> + > >> +RT5033 is a Multifunction device which includes battery charger, fuel gauge, > >> +flash LED current source, LDO and synchronous Buck converter for portable > >> +applications. It is interfaced to host controller using i2c interface. > >> + > >> +Required properties: > >> +- compatible : Must be "richtek,rt5033" > >> +- reg : Specifies the i2c slave address of general part. > >> +- interrupts : This i2c devices has an IRQ line connected to the main SoC. > >> +- interrupt-parent : The parent interrupt controller. > >> + > >> +Optional node: > >> +Regulators: The regulators of RT5033 have to be instantiated under sub-node > >> +named "regulators" using the following format. > >> + > >> + regulators { > >> + regulator-name { > >> + regulator-name = LDO/BUCK > >> + regulator subnodes called X, Y and Z > >> + }; > >> + }; > >> + refer Documentation/devicetree/bindings/regulator/regulator.txt > >> + > >> + > >> +Battery charger: There battery charger of RT5033 have to be instantiated under > >> +sub-node named "charger" using the following format. > >> + > >> +Required properties: > >> +- compatible : Must be "richtek,rt5033-charger". > >> +- richtek,pre-uamp : Current of pre-charge mode. The pre-charge current levels > >> + are 350 mA to 650 mA programmed by I2C per 100 mA. > >> +- richtek,fast-uamp : Current of fast-charge mode. The fast-charge current > >> + levels are 700 mA to 2000 mA programmed by I2C per 100 mA. > >> +- richtek,eoc-uamp : This property is end of charge current. Its level 150 mA > >> + to 200 mA. > >> +- richtek,pre-threshold-uvolt : Voltage of threshold pre-charge mode. Battery > >> + voltage is below pre-charge threshold voltage, the charger is in pre-charge > >> + mode with pre-charge current. Its levels are 2.3 V to 3.8 V programmed > >> + by I2C per 0.1 V. > >> +- richtek,const-uvolt : Battery regulation voltage of constant voltage mode. > >> + This voltage level 3.65 V to 4.4 V bye I2C per 0.025 V. > >> + > >> + charger { > >> + compatible = "richtek,rt5033-charger"; > >> + richtek,pre-uamp = <350000>; > >> + richtek,fast-uamp = <2000000>; > >> + richtek,eoc-uamp = <250000>; > >> + richtek,pre-threshold-uvolt = <3400000>; > >> + richtek,const-uvolt = <4350000>; > >> + > >> + }; > >> + > >> + > >> +Fuelgauge: There fuelgauge of RT5033 to be instantiated node named "fuelgauge" > >> +using the following format. > >> + > >> +Required properties: > >> +- compatible = Must be "richtek,rt5033-battery". > >> + > >> + rt5033@35 { > >> + compatible = "richtek,rt5033-battery"; > >> + interrupt-parent = <&gpx2>; > >> + interrupts = <3 0>; > >> + reg = <0x35>; > >> + }; > >> + > >> +Example: > >> + > >> + rt5033@34 { > >> + compatible = "richtek,rt5033"; > >> + reg = <0x34>; > >> + interrupt-parent = <&gpx1>; > >> + interrupts = <5 0>; > >> + > >> + regulators { > >> + buck_reg: BUCK { > >> + regulator-name = "BUCK"; > >> + regulator-min-microvolt = <1200000>; > >> + regulator-max-microvolt = <1200000>; > >> + regulator-always-on; > >> + }; > >> + }; > >> + > >> + charger { > >> + compatible = "richtek,rt5033-charger"; > >> + richtek,pre-uamp = <350000>; > >> + richtek,fast-uamp = <2000000>; > >> + richtek,eoc-uamp = <250000>; > >> + richtek,pre-threshold-uvolt = <3400000>; > >> + richtek,const-uvolt = <4350000>; > >> + }; > >> + > >> + }; > >> + > >> + rt5033@35 { > >> + compatible = "richtek,rt5033-battery"; > >> + interrupt-parent = <&gpx2>; > >> + interrupts = <3 0>; > >> + reg = <0x35>; > >> + }; > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > >> index b1df0ad..b6a2ca1 100644 > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > >> @@ -134,6 +134,7 @@ ralink Mediatek/Ralink Technology Corp. > >> ramtron Ramtron International > >> realtek Realtek Semiconductor Corp. > >> renesas Renesas Electronics Corporation > >> +richtek Richtek Technology Corporation > >> ricoh Ricoh Co. Ltd. > >> rockchip Fuzhou Rockchip Electronics Co., Ltd > >> samsung Samsung Semiconductor > > > > Thanks, > Beomho Seo
On 01/22/2015 06:02 PM, Lee Jones wrote: > On Thu, 22 Jan 2015, Beomho Seo wrote: > >> On 01/22/2015 04:41 PM, Lee Jones wrote: >>> On Thu, 22 Jan 2015, Beomho Seo wrote: >>> >>>> This patch device tree binding documentation for rt5033 multifunction device. >>>> >>>> Cc: Sebastian Reichel <sre@kernel.org> >>>> Cc: Lee Jones <lee.jones@linaro.org> >>>> Cc: Mark Brown <broonie@kernel.org> >>>> Cc: Rob Herring <robh+dt@kernel.org> >>>> Cc: Pawel Moll <pawel.moll@arm.com> >>>> Cc: Mark Rutland <mark.rutland@arm.com> >>>> Cc: Ian campbell <ijc+devicetree@hellion.org.uk> >>>> Cc: Kumar Gala <galak@codeaurora.org> >>>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> >>>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> >>>> Acked-by: Lee Jones <lee.jones@linaro.org> >>> >>> I did not Ack this patch. >>> >>> Your new vendor bindings require a DT Ack. >>> >>> Although, as the ones I'm concerned with are Regulator related, and >>> Ack from Mark Brown will also suffice. >>> >> >> I want to apologize for my mistake. I completely misunderstood your reply. >> Unfortunately, This patch merged by Sebastian at his git. >> Please tell me what to do. > > That's strange, as I haven't heard anything from Sebastian. > > Anyway, he needs to remove it from his tree until we receive a > suitable Ack. > OK, If Sebastian remove it from his tree, I will fix Acked-by. And then wait receive a suitable Ack. >>>> --- >>>> Changes in v4 >>>> - none. >>>> Changes in v3 >>>> - Add Acked-by >>>> Changes in v2 >>>> - Fix incorrect typo. >>>> - Align -uamp and -uvolt names with regulator binding suffixes. >>>> - Drop incorrect phandle. >>>> - Fix incorrect example. >>>> --- >>>> >>>> Documentation/devicetree/bindings/mfd/rt5033.txt | 101 ++++++++++++++++++++ >>>> .../devicetree/bindings/vendor-prefixes.txt | 1 + >>>> 2 files changed, 102 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/rt5033.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/rt5033.txt b/Documentation/devicetree/bindings/mfd/rt5033.txt >>>> new file mode 100644 >>>> index 0000000..64b23e8 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mfd/rt5033.txt >>>> @@ -0,0 +1,101 @@ >>>> +Richtek RT5033 Power management Integrated Circuit >>>> + >>>> +RT5033 is a Multifunction device which includes battery charger, fuel gauge, >>>> +flash LED current source, LDO and synchronous Buck converter for portable >>>> +applications. It is interfaced to host controller using i2c interface. >>>> + >>>> +Required properties: >>>> +- compatible : Must be "richtek,rt5033" >>>> +- reg : Specifies the i2c slave address of general part. >>>> +- interrupts : This i2c devices has an IRQ line connected to the main SoC. >>>> +- interrupt-parent : The parent interrupt controller. >>>> + >>>> +Optional node: >>>> +Regulators: The regulators of RT5033 have to be instantiated under sub-node >>>> +named "regulators" using the following format. >>>> + >>>> + regulators { >>>> + regulator-name { >>>> + regulator-name = LDO/BUCK >>>> + regulator subnodes called X, Y and Z >>>> + }; >>>> + }; >>>> + refer Documentation/devicetree/bindings/regulator/regulator.txt >>>> + >>>> + >>>> +Battery charger: There battery charger of RT5033 have to be instantiated under >>>> +sub-node named "charger" using the following format. >>>> + >>>> +Required properties: >>>> +- compatible : Must be "richtek,rt5033-charger". >>>> +- richtek,pre-uamp : Current of pre-charge mode. The pre-charge current levels >>>> + are 350 mA to 650 mA programmed by I2C per 100 mA. >>>> +- richtek,fast-uamp : Current of fast-charge mode. The fast-charge current >>>> + levels are 700 mA to 2000 mA programmed by I2C per 100 mA. >>>> +- richtek,eoc-uamp : This property is end of charge current. Its level 150 mA >>>> + to 200 mA. >>>> +- richtek,pre-threshold-uvolt : Voltage of threshold pre-charge mode. Battery >>>> + voltage is below pre-charge threshold voltage, the charger is in pre-charge >>>> + mode with pre-charge current. Its levels are 2.3 V to 3.8 V programmed >>>> + by I2C per 0.1 V. >>>> +- richtek,const-uvolt : Battery regulation voltage of constant voltage mode. >>>> + This voltage level 3.65 V to 4.4 V bye I2C per 0.025 V. >>>> + >>>> + charger { >>>> + compatible = "richtek,rt5033-charger"; >>>> + richtek,pre-uamp = <350000>; >>>> + richtek,fast-uamp = <2000000>; >>>> + richtek,eoc-uamp = <250000>; >>>> + richtek,pre-threshold-uvolt = <3400000>; >>>> + richtek,const-uvolt = <4350000>; >>>> + >>>> + }; >>>> + >>>> + >>>> +Fuelgauge: There fuelgauge of RT5033 to be instantiated node named "fuelgauge" >>>> +using the following format. >>>> + >>>> +Required properties: >>>> +- compatible = Must be "richtek,rt5033-battery". >>>> + >>>> + rt5033@35 { >>>> + compatible = "richtek,rt5033-battery"; >>>> + interrupt-parent = <&gpx2>; >>>> + interrupts = <3 0>; >>>> + reg = <0x35>; >>>> + }; >>>> + >>>> +Example: >>>> + >>>> + rt5033@34 { >>>> + compatible = "richtek,rt5033"; >>>> + reg = <0x34>; >>>> + interrupt-parent = <&gpx1>; >>>> + interrupts = <5 0>; >>>> + >>>> + regulators { >>>> + buck_reg: BUCK { >>>> + regulator-name = "BUCK"; >>>> + regulator-min-microvolt = <1200000>; >>>> + regulator-max-microvolt = <1200000>; >>>> + regulator-always-on; >>>> + }; >>>> + }; >>>> + >>>> + charger { >>>> + compatible = "richtek,rt5033-charger"; >>>> + richtek,pre-uamp = <350000>; >>>> + richtek,fast-uamp = <2000000>; >>>> + richtek,eoc-uamp = <250000>; >>>> + richtek,pre-threshold-uvolt = <3400000>; >>>> + richtek,const-uvolt = <4350000>; >>>> + }; >>>> + >>>> + }; >>>> + >>>> + rt5033@35 { >>>> + compatible = "richtek,rt5033-battery"; >>>> + interrupt-parent = <&gpx2>; >>>> + interrupts = <3 0>; >>>> + reg = <0x35>; >>>> + }; >>>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt >>>> index b1df0ad..b6a2ca1 100644 >>>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt >>>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt >>>> @@ -134,6 +134,7 @@ ralink Mediatek/Ralink Technology Corp. >>>> ramtron Ramtron International >>>> realtek Realtek Semiconductor Corp. >>>> renesas Renesas Electronics Corporation >>>> +richtek Richtek Technology Corporation >>>> ricoh Ricoh Co. Ltd. >>>> rockchip Fuzhou Rockchip Electronics Co., Ltd >>>> samsung Samsung Semiconductor >>> >> >> Thanks, >> Beomho Seo > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thu, Jan 22, 2015 at 09:02:43AM +0000, Lee Jones wrote: > On Thu, 22 Jan 2015, Beomho Seo wrote: > > > On 01/22/2015 04:41 PM, Lee Jones wrote: > > > On Thu, 22 Jan 2015, Beomho Seo wrote: > > > > > >> This patch device tree binding documentation for rt5033 multifunction device. > > >> > > >> Cc: Sebastian Reichel <sre@kernel.org> > > >> Cc: Lee Jones <lee.jones@linaro.org> > > >> Cc: Mark Brown <broonie@kernel.org> > > >> Cc: Rob Herring <robh+dt@kernel.org> > > >> Cc: Pawel Moll <pawel.moll@arm.com> > > >> Cc: Mark Rutland <mark.rutland@arm.com> > > >> Cc: Ian campbell <ijc+devicetree@hellion.org.uk> > > >> Cc: Kumar Gala <galak@codeaurora.org> > > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > > >> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > > >> Acked-by: Lee Jones <lee.jones@linaro.org> > > > > > > I did not Ack this patch. > > > > > > Your new vendor bindings require a DT Ack. > > > > > > Although, as the ones I'm concerned with are Regulator related, and > > > Ack from Mark Brown will also suffice. > > > > > > > I want to apologize for my mistake. I completely misunderstood your reply. > > Unfortunately, This patch merged by Sebastian at his git. > > Please tell me what to do. > > That's strange, as I haven't heard anything from Sebastian. Right, Beomho had a typo in your mail address on patch 0/2 (to which I replied). > Anyway, he needs to remove it from his tree until we receive a > suitable Ack. I removed both patches some hours ago. -- Sebastian
diff --git a/Documentation/devicetree/bindings/mfd/rt5033.txt b/Documentation/devicetree/bindings/mfd/rt5033.txt new file mode 100644 index 0000000..64b23e8 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/rt5033.txt @@ -0,0 +1,101 @@ +Richtek RT5033 Power management Integrated Circuit + +RT5033 is a Multifunction device which includes battery charger, fuel gauge, +flash LED current source, LDO and synchronous Buck converter for portable +applications. It is interfaced to host controller using i2c interface. + +Required properties: +- compatible : Must be "richtek,rt5033" +- reg : Specifies the i2c slave address of general part. +- interrupts : This i2c devices has an IRQ line connected to the main SoC. +- interrupt-parent : The parent interrupt controller. + +Optional node: +Regulators: The regulators of RT5033 have to be instantiated under sub-node +named "regulators" using the following format. + + regulators { + regulator-name { + regulator-name = LDO/BUCK + regulator subnodes called X, Y and Z + }; + }; + refer Documentation/devicetree/bindings/regulator/regulator.txt + + +Battery charger: There battery charger of RT5033 have to be instantiated under +sub-node named "charger" using the following format. + +Required properties: +- compatible : Must be "richtek,rt5033-charger". +- richtek,pre-uamp : Current of pre-charge mode. The pre-charge current levels + are 350 mA to 650 mA programmed by I2C per 100 mA. +- richtek,fast-uamp : Current of fast-charge mode. The fast-charge current + levels are 700 mA to 2000 mA programmed by I2C per 100 mA. +- richtek,eoc-uamp : This property is end of charge current. Its level 150 mA + to 200 mA. +- richtek,pre-threshold-uvolt : Voltage of threshold pre-charge mode. Battery + voltage is below pre-charge threshold voltage, the charger is in pre-charge + mode with pre-charge current. Its levels are 2.3 V to 3.8 V programmed + by I2C per 0.1 V. +- richtek,const-uvolt : Battery regulation voltage of constant voltage mode. + This voltage level 3.65 V to 4.4 V bye I2C per 0.025 V. + + charger { + compatible = "richtek,rt5033-charger"; + richtek,pre-uamp = <350000>; + richtek,fast-uamp = <2000000>; + richtek,eoc-uamp = <250000>; + richtek,pre-threshold-uvolt = <3400000>; + richtek,const-uvolt = <4350000>; + + }; + + +Fuelgauge: There fuelgauge of RT5033 to be instantiated node named "fuelgauge" +using the following format. + +Required properties: +- compatible = Must be "richtek,rt5033-battery". + + rt5033@35 { + compatible = "richtek,rt5033-battery"; + interrupt-parent = <&gpx2>; + interrupts = <3 0>; + reg = <0x35>; + }; + +Example: + + rt5033@34 { + compatible = "richtek,rt5033"; + reg = <0x34>; + interrupt-parent = <&gpx1>; + interrupts = <5 0>; + + regulators { + buck_reg: BUCK { + regulator-name = "BUCK"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + }; + }; + + charger { + compatible = "richtek,rt5033-charger"; + richtek,pre-uamp = <350000>; + richtek,fast-uamp = <2000000>; + richtek,eoc-uamp = <250000>; + richtek,pre-threshold-uvolt = <3400000>; + richtek,const-uvolt = <4350000>; + }; + + }; + + rt5033@35 { + compatible = "richtek,rt5033-battery"; + interrupt-parent = <&gpx2>; + interrupts = <3 0>; + reg = <0x35>; + }; diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index b1df0ad..b6a2ca1 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -134,6 +134,7 @@ ralink Mediatek/Ralink Technology Corp. ramtron Ramtron International realtek Realtek Semiconductor Corp. renesas Renesas Electronics Corporation +richtek Richtek Technology Corporation ricoh Ricoh Co. Ltd. rockchip Fuzhou Rockchip Electronics Co., Ltd samsung Samsung Semiconductor