Patchwork Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2

login
register
mail settings
Submitter stephen hemminger
Date Jan. 18, 2010, 7:52 p.m.
Message ID <20100118115224.1abde88b@nehalam>
Download mbox | patch
Permalink /patch/43151/
State RFC
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Jan. 18, 2010, 7:52 p.m.
Does it work better if config bit is set here?

---
 drivers/net/sky2.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tino Keitel - Jan. 18, 2010, 8:58 p.m.
On Mon, Jan 18, 2010 at 11:52:24 -0800, Stephen Hemminger wrote:
> Does it work better if config bit is set here?

No, still the same problem.

Regards,
Tino
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/net/sky2.c	2010-01-18 11:45:54.444753324 -0800
+++ b/drivers/net/sky2.c	2010-01-18 11:49:18.475018945 -0800
@@ -283,6 +283,9 @@  static void sky2_power_aux(struct sky2_h
 
 	/* turn off "driver loaded LED" */
 	sky2_write16(hw, B0_CTST, Y2_LED_STAT_OFF);
+
+	/* disable writes to PCI config again */
+	sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
 }
 
 static void sky2_gmac_reset(struct sky2_hw *hw, unsigned port)