| Message ID | 20100118171504.14623.11688.sendpatchset@localhost |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Hello. Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] pata_cmd64x: fix handling of address setup timings > > Account for the requirements of the DMA mode currently used > by the pair device. > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > --- > drivers/ata/pata_cmd64x.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > Index: b/drivers/ata/pata_cmd64x.c > =================================================================== > --- a/drivers/ata/pata_cmd64x.c > +++ b/drivers/ata/pata_cmd64x.c > @@ -165,8 +165,14 @@ static void cmd64x_set_timing(struct ata > > if (pair) { > struct ata_timing tp; > + > ata_timing_compute(pair, pair->pio_mode, &tp, T, 0); > ata_timing_merge(&t, &tp, &t, ATA_TIMING_SETUP); > + if (pair->dma_mode) { > + ata_timing_compute(pair, pair->dma_mode, > + &tp, T, 0); > + ata_timing_merge(&tp, &t, &t, ATA_TIMING_SETUP); > I wonder where Jeff has got the address setup timings for the DMA modes... MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ata/pata_cmd64x.c =================================================================== --- a/drivers/ata/pata_cmd64x.c +++ b/drivers/ata/pata_cmd64x.c @@ -165,8 +165,14 @@ static void cmd64x_set_timing(struct ata if (pair) { struct ata_timing tp; + ata_timing_compute(pair, pair->pio_mode, &tp, T, 0); ata_timing_merge(&t, &tp, &t, ATA_TIMING_SETUP); + if (pair->dma_mode) { + ata_timing_compute(pair, pair->dma_mode, + &tp, T, 0); + ata_timing_merge(&tp, &t, &t, ATA_TIMING_SETUP); + } } }