From patchwork Mon Jan 18 17:17:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 43140 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3BCC3B7C63 for ; Tue, 19 Jan 2010 04:31:53 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548Ab0ARRSY (ORCPT ); Mon, 18 Jan 2010 12:18:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754866Ab0ARRSR (ORCPT ); Mon, 18 Jan 2010 12:18:17 -0500 Received: from mail-fx0-f225.google.com ([209.85.220.225]:57477 "EHLO mail-fx0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754849Ab0ARRSP (ORCPT ); Mon, 18 Jan 2010 12:18:15 -0500 Received: by mail-fx0-f225.google.com with SMTP id 25so680400fxm.21 for ; Mon, 18 Jan 2010 09:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:date:message-id :in-reply-to:references:subject; bh=T/pHG4yRdptCV9h7yeKy3+7K6iqXavAeUOdZA3qcwPI=; b=pUPuRYDMhQRO9uk1rC69Bgf9hTrooYV9ZZh9eRAL2U4PjncYNIVgKZP+TXsIICyggk 1uUVVKE94yuVtgtTjkgQd3tTmoRR3diR9gD+HsbR0XwOcbPPO1MmOv0gs5qptbJm1A91 g0wJK36wy1O2D2X0KO0aZPXkOSvjQBOzJA5Ro= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=vYptqEAPGGa2rZrhzcA4cRGwo6Jz03mo8aX8vki/Zyi/xnRi8rv/vFykP4OdQpWQ1W aQy6TCxQYY1pVSe0IqBVoz+F1Txs7ZCPkWONPj0MU6z6u1Z7MRBY84eJ7rkKJyaV0k2h UxP3M1AzH7VAW12hT37TrnBgQHcGJHsDpdZeA= Received: by 10.216.89.202 with SMTP id c52mr2160627wef.215.1263835094392; Mon, 18 Jan 2010 09:18:14 -0800 (PST) Received: from ?127.0.0.1? (chello089079027028.chello.pl [89.79.27.28]) by mx.google.com with ESMTPS id t2sm4580657gve.24.2010.01.18.09.18.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Jan 2010 09:18:12 -0800 (PST) From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Mon, 18 Jan 2010 18:17:03 +0100 Message-Id: <20100118171703.14623.85025.sendpatchset@localhost> In-Reply-To: <20100118171349.14623.90030.sendpatchset@localhost> References: <20100118171349.14623.90030.sendpatchset@localhost> Subject: [PATCH 22/64] pata_via: fix address setup timings underlocking Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Bartlomiej Zolnierkiewicz Subject: [PATCH] pata_via: fix address setup timings underlocking Correct via_do_set_mode() documentation while at it. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ata/pata_via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/ata/pata_via.c =================================================================== --- a/drivers/ata/pata_via.c +++ b/drivers/ata/pata_via.c @@ -229,7 +229,7 @@ static int via_pre_reset(struct ata_link /** - * via_do_set_mode - set initial PIO mode data + * via_do_set_mode - set transfer mode data * @ap: ATA interface * @adev: ATA device * @mode: ATA mode being programmed @@ -273,7 +273,7 @@ static void via_do_set_mode(struct ata_p pci_read_config_byte(pdev, 0x4C, &setup); setup &= ~(3 << shift); - setup |= clamp_val(t.setup, 1, 4) << shift; /* 1,4 or 1,4 - 1 FIXME */ + setup |= (clamp_val(t.setup, 1, 4) - 1) << shift; pci_write_config_byte(pdev, 0x4C, setup); }