From patchwork Mon Jan 18 17:17:59 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 43099 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6B98EB7C9D for ; Tue, 19 Jan 2010 04:20:14 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755150Ab0ARRTv (ORCPT ); Mon, 18 Jan 2010 12:19:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755051Ab0ARRTY (ORCPT ); Mon, 18 Jan 2010 12:19:24 -0500 Received: from mail-ew0-f214.google.com ([209.85.219.214]:52797 "EHLO mail-ew0-f214.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755039Ab0ARRTT (ORCPT ); Mon, 18 Jan 2010 12:19:19 -0500 Received: by mail-ew0-f214.google.com with SMTP id 6so3708367ewy.29 for ; Mon, 18 Jan 2010 09:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:date:message-id :in-reply-to:references:subject; bh=lMoUorn6di7+lsIaFP/H1abp0/xeEQMhQEHeIRhra/E=; b=GtNckFHz/9eSpZYUCXdsjUDvnCrQhab4R7lm12skxK7RZ/V0mXRQRIiXpqo44vNnbs k4F1aYlu556/jfmxJT0qeTZL9FUqiec4Rmms7aNNqk2DSNxnvZBObEfRmBL4DuuyVGpq hlEAcMNcZiByJ1KbyzZtSdCYVcgBRUhjlgOWc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=Pf5w13WI910AXasbaNj205pUQCTNMwiblARHFI6GCFz52RVBEvv2X7gIBlsodpS/Re GdM1lmU/zibYmatiJ40i+gvGK9e/qJyajT725iYiQXbVmdKYxiLwBhX22DNeyXCBAVpb Yo7q+lWFRBPe2km4x2SzFLDfA0G3Kld42FpqU= Received: by 10.216.87.11 with SMTP id x11mr2480994wee.16.1263835149334; Mon, 18 Jan 2010 09:19:09 -0800 (PST) Received: from ?127.0.0.1? (chello089079027028.chello.pl [89.79.27.28]) by mx.google.com with ESMTPS id t12sm8113120gvd.5.2010.01.18.09.19.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Jan 2010 09:19:08 -0800 (PST) From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Mon, 18 Jan 2010 18:17:59 +0100 Message-Id: <20100118171759.14623.53556.sendpatchset@localhost> In-Reply-To: <20100118171349.14623.90030.sendpatchset@localhost> References: <20100118171349.14623.90030.sendpatchset@localhost> Subject: [PATCH 28/64] alim15x3: remove superfluous locking from ali_set_pio_mode() Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Bartlomiej Zolnierkiewicz Subject: [PATCH] alim15x3: remove superfluous locking from ali_set_pio_mode() Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ide/alim15x3.c | 5 ----- 1 file changed, 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/ide/alim15x3.c =================================================================== --- a/drivers/ide/alim15x3.c +++ b/drivers/ide/alim15x3.c @@ -73,7 +73,6 @@ static void ali_set_pio_mode(ide_drive_t { ide_hwif_t *hwif = drive->hwif; struct pci_dev *dev = to_pci_dev(hwif->dev); - unsigned long flags; int bus_speed = ide_pci_clk ? ide_pci_clk : 33; unsigned long T = 1000000 / bus_speed; /* PCI clock based */ int port = hwif->channel ? 0x5c : 0x58; @@ -86,8 +85,6 @@ static void ali_set_pio_mode(ide_drive_t t.active = clamp_val(t.active, 1, 8) & 7; t.recover = clamp_val(t.recover, 1, 16) & 15; - local_irq_save(flags); - /* * PIO mode => ATA FIFO on, ATAPI FIFO off */ @@ -96,8 +93,6 @@ static void ali_set_pio_mode(ide_drive_t pci_write_config_byte(dev, port, t.setup); pci_write_config_byte(dev, port + unit + 2, (t.active << 4) | t.recover); - - local_irq_restore(flags); } /**