From patchwork Mon Jan 18 17:18:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 43097 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3E69DB7C9D for ; Tue, 19 Jan 2010 04:20:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755058Ab0ARRT0 (ORCPT ); Mon, 18 Jan 2010 12:19:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754910Ab0ARRTZ (ORCPT ); Mon, 18 Jan 2010 12:19:25 -0500 Received: from mail-fx0-f225.google.com ([209.85.220.225]:39792 "EHLO mail-fx0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755044Ab0ARRTV (ORCPT ); Mon, 18 Jan 2010 12:19:21 -0500 Received: by mail-fx0-f225.google.com with SMTP id 25so681812fxm.21 for ; Mon, 18 Jan 2010 09:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:date:message-id :in-reply-to:references:subject; bh=Fc8VZ6k0+TH4MPZqBncqbWlLltpXDVOftazpAfBqbmM=; b=aYOrocYlGqUTzYF5TVJQkhNC2Vo7RDgKZ8qqIl1l7Z1vB09ZsPywvc9k1YzZjW2sRp Lc3N3HER5aebfXwvJJVW8bB4gWv+4NiC5FeiAR3z7010XRvz1niZAB07jgsXTEl330aH OQnfPKEBeD12jHOOb2yXvP0beix7i4pZPWKuI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=mmRsfnWSLqJvkL5vcb2hk5vtu1jzGzxJgjw6wVQptF7wGVtj8yzSFuA1295ZgqrRX7 C0TMYAsLZ6RNjgGFJU3+ygVBXZGc8TG02Fmg6zlAbZ05dYPmtD507mWgbOdHPGzxMDGo 2ss/bKczNue/Lg3OdGHvwFiwW+3fNDKQrWdew= Received: by 10.216.89.70 with SMTP id b48mr319345wef.160.1263835159115; Mon, 18 Jan 2010 09:19:19 -0800 (PST) Received: from ?127.0.0.1? (chello089079027028.chello.pl [89.79.27.28]) by mx.google.com with ESMTPS id t12sm8173977gvd.20.2010.01.18.09.19.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Jan 2010 09:19:16 -0800 (PST) From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Mon, 18 Jan 2010 18:18:07 +0100 Message-Id: <20100118171807.14623.50469.sendpatchset@localhost> In-Reply-To: <20100118171349.14623.90030.sendpatchset@localhost> References: <20100118171349.14623.90030.sendpatchset@localhost> Subject: [PATCH 29/64] alim15x3: cleanup ali_cable_detect() Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Bartlomiej Zolnierkiewicz Subject: [PATCH] alim15x3: cleanup ali_cable_detect() Remove leftover local_irq_[save,restore]() and FIXME note. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ide/alim15x3.c | 8 -------- 1 file changed, 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/ide/alim15x3.c =================================================================== --- a/drivers/ide/alim15x3.c +++ b/drivers/ide/alim15x3.c @@ -345,19 +345,13 @@ static int ali_cable_override(struct pci * * This checks if the controller and the cable are capable * of UDMA66 transfers. It doesn't check the drives. - * But see note 2 below! - * - * FIXME: frobs bits that are not defined on newer ALi devicea */ static u8 ali_cable_detect(ide_hwif_t *hwif) { struct pci_dev *dev = to_pci_dev(hwif->dev); - unsigned long flags; u8 cbl = ATA_CBL_PATA40, tmpbyte; - local_irq_save(flags); - if (m5229_revision >= 0xC2) { /* * m5229 80-pin cable detection (from Host View) @@ -377,8 +371,6 @@ static u8 ali_cable_detect(ide_hwif_t *h } } - local_irq_restore(flags); - return cbl; }