Patchwork [net-2.6] sfc: QT202x: Remove unreliable MMD check at initialisation

login
register
mail settings
Submitter Ben Hutchings
Date Jan. 18, 2010, 3:47 p.m.
Message ID <1263829636.3667.3.camel@achroite.uk.solarflarecom.com>
Download mbox | patch
Permalink /patch/43076/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - Jan. 18, 2010, 3:47 p.m.
From: Matthew Slattery <mslattery@solarflare.com>

Checking the PHY XS MMD here is unnecessary and can give false negatives.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 drivers/net/sfc/qt202x_phy.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
David Miller - Jan. 19, 2010, 10 a.m.
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 18 Jan 2010 15:47:16 +0000

> From: Matthew Slattery <mslattery@solarflare.com>
> 
> Checking the PHY XS MMD here is unnecessary and can give false negatives.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

Applied.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/sfc/qt202x_phy.c b/drivers/net/sfc/qt202x_phy.c
index ff8f0a4..e0d13a4 100644
--- a/drivers/net/sfc/qt202x_phy.c
+++ b/drivers/net/sfc/qt202x_phy.c
@@ -318,12 +318,6 @@  static int qt202x_reset_phy(struct efx_nic *efx)
 	/* Wait 250ms for the PHY to complete bootup */
 	msleep(250);
 
-	/* Check that all the MMDs we expect are present and responding. We
-	 * expect faults on some if the link is down, but not on the PHY XS */
-	rc = efx_mdio_check_mmds(efx, QT202X_REQUIRED_DEVS, MDIO_DEVS_PHYXS);
-	if (rc < 0)
-		goto fail;
-
 	falcon_board(efx)->type->init_phy(efx);
 
 	return rc;