| Message ID | 1421710198-20898-4-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Rejected |
| Headers | show |
Hi Romain, On Tue, Jan 20, 2015 at 12:29:58AM +0100, Romain Naour wrote: > Syslinux use a perl interpreter in it's build system, > so add host-perl as dependency. Buildroot expects perl to be installed on the host system already. See §2.1 (Mandatory packages) in the manual. AFAIK host-perl is only used to build perl itself for the target. Have you encountered any specific build failure? baruch
Hi Baruch, Le 20/01/2015 09:54, Baruch Siach a écrit : > Hi Romain, > > On Tue, Jan 20, 2015 at 12:29:58AM +0100, Romain Naour wrote: >> Syslinux use a perl interpreter in it's build system, >> so add host-perl as dependency. > > Buildroot expects perl to be installed on the host system already. See §2.1 > (Mandatory packages) in the manual. AFAIK host-perl is only used to build perl > itself for the target. Thanks for the reminder, I haven't checked if perl was a mandatory packages before sending the patch... > > Have you encountered any specific build failure? Not at all. Best regards, Romain > > baruch >
Dear Romain Naour, On Tue, 20 Jan 2015 21:27:22 +0100, Romain Naour wrote: > > Buildroot expects perl to be installed on the host system already. See §2.1 > > (Mandatory packages) in the manual. AFAIK host-perl is only used to build perl > > itself for the target. > > Thanks for the reminder, I haven't checked if perl was a mandatory packages > before sending the patch... > > > Have you encountered any specific build failure? > > Not at all. So I'll mark the patch as Rejected in patchwork. Thanks Romain and Baruch. Thomas
diff --git a/boot/syslinux/syslinux.mk b/boot/syslinux/syslinux.mk index 7ec840e..c8107f1 100644 --- a/boot/syslinux/syslinux.mk +++ b/boot/syslinux/syslinux.mk @@ -13,7 +13,7 @@ SYSLINUX_LICENSE_FILES = COPYING SYSLINUX_INSTALL_IMAGES = YES -SYSLINUX_DEPENDENCIES = host-nasm host-util-linux host-upx +SYSLINUX_DEPENDENCIES = host-nasm host-perl host-util-linux host-upx ifeq ($(BR2_TARGET_SYSLINUX_LEGACY_BIOS),y) SYSLINUX_TARGET = bios
Syslinux use a perl interpreter in it's build system, so add host-perl as dependency. Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- boot/syslinux/syslinux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)