| Message ID | 1421511231-14482-1-git-send-email-rickard_strandqvist@spectrumdigital.se |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, Jan 17, 2015 at 10:13 AM, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote: > Remove the function tipc_link_get_max_pkt() that is not used anywhere. This is already in the next tree: commit 54fef04ad05f15984082c225fe47ce6af8ea1c5c Author: Ying Xue <ying.xue@windriver.com> Date: Fri Jan 9 15:27:03 2015 +0800 tipc: remove unused tipc_link_get_max_pkt routine Signed-off-by: Ying Xue <ying.xue@windriver.com> Tested-by: Tero Aho <Tero.Aho@coriant.com> Reviewed-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-01-17 17:55 GMT+01:00 Chris Rorvick <chris@rorvick.com>: > On Sat, Jan 17, 2015 at 10:13 AM, Rickard Strandqvist > <rickard_strandqvist@spectrumdigital.se> wrote: >> Remove the function tipc_link_get_max_pkt() that is not used anywhere. > > This is already in the next tree: > > commit 54fef04ad05f15984082c225fe47ce6af8ea1c5c > Author: Ying Xue <ying.xue@windriver.com> > Date: Fri Jan 9 15:27:03 2015 +0800 > > tipc: remove unused tipc_link_get_max_pkt routine > > Signed-off-by: Ying Xue <ying.xue@windriver.com> > Tested-by: Tero Aho <Tero.Aho@coriant.com> > Reviewed-by: Jon Maloy <jon.maloy@ericsson.com> > Signed-off-by: David S. Miller <davem@davemloft.net> Hi Ok sorry, I update my linux-next clon Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/tipc/link.c b/net/tipc/link.c index 23bcc11..e92fcfb 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c @@ -2266,33 +2266,6 @@ struct sk_buff *tipc_link_cmd_show_stats(const void *req_tlv_area, int req_tlv_s return buf; } -/** - * tipc_link_get_max_pkt - get maximum packet size to use when sending to destination - * @dest: network address of destination node - * @selector: used to select from set of active links - * - * If no active link can be found, uses default maximum packet size. - */ -u32 tipc_link_get_max_pkt(u32 dest, u32 selector) -{ - struct tipc_node *n_ptr; - struct tipc_link *l_ptr; - u32 res = MAX_PKT_DEFAULT; - - if (dest == tipc_own_addr) - return MAX_MSG_SIZE; - - n_ptr = tipc_node_find(dest); - if (n_ptr) { - tipc_node_lock(n_ptr); - l_ptr = n_ptr->active_links[selector & 1]; - if (l_ptr) - res = l_ptr->max_pkt; - tipc_node_unlock(n_ptr); - } - return res; -} - static void link_print(struct tipc_link *l_ptr, const char *str) { struct tipc_bearer *b_ptr; diff --git a/net/tipc/link.h b/net/tipc/link.h index 55812e8..084bd4e 100644 --- a/net/tipc/link.h +++ b/net/tipc/link.h @@ -216,7 +216,6 @@ void tipc_link_reset_list(unsigned int bearer_id); int tipc_link_xmit_skb(struct sk_buff *skb, u32 dest, u32 selector); int tipc_link_xmit(struct sk_buff_head *list, u32 dest, u32 selector); int __tipc_link_xmit(struct tipc_link *link, struct sk_buff_head *list); -u32 tipc_link_get_max_pkt(u32 dest, u32 selector); void tipc_link_bundle_rcv(struct sk_buff *buf); void tipc_link_proto_xmit(struct tipc_link *l_ptr, u32 msg_typ, int prob, u32 gap, u32 tolerance, u32 priority, u32 acked_mtu);
Remove the function tipc_link_get_max_pkt() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- net/tipc/link.c | 27 --------------------------- net/tipc/link.h | 1 - 2 files changed, 28 deletions(-)