Message ID | 1421402411-3479-3-git-send-email-chunyan.zhang@spreadtrum.com |
---|---|
State | Accepted, archived |
Commit | e570f6bca4a5d23a4cff4746257fb06666d1d8d4 |
Headers | show |
Hi, Mark >> + >> +Required properties: >> +- compatible: must be "sprd,sc9836-uart" >> +- reg: offset and length of the register set for the device >> +- interrupts: exactly one interrupt specifier >> +- clocks: phandles to input clocks. > > The order and relevance of each should be specified. If you have > multiple clocks I would strongly recommend you use clock-names to > distinguish them. > Thank you for the recommendation. but, since we haven't made the clock driver ready, for this initial commit, we just let 4 UARTs share a single fixed 26 MHz clock source. we'll do like you've recommended when we will submit the clock driver in the future. Best regards, Chunyan > Otherwise this looks fine. > > Mark. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 16, 2015 at 12:53:16PM +0000, Lyra Zhang wrote: > Hi, Mark > > >> + > >> +Required properties: > >> +- compatible: must be "sprd,sc9836-uart" > >> +- reg: offset and length of the register set for the device > >> +- interrupts: exactly one interrupt specifier > >> +- clocks: phandles to input clocks. > > > > The order and relevance of each should be specified. If you have > > multiple clocks I would strongly recommend you use clock-names to > > distinguish them. > > > > Thank you for the recommendation. > but, since we haven't made the clock driver ready, for this initial > commit, we just let 4 UARTs share a single fixed 26 MHz clock source. > we'll do like you've recommended when we will submit the clock driver > in the future. I'm on about the clock input lines on the UART instance, not the providers they come from. Is there only a single clock input line on each UART? Perhaps multiple input lines which are currently fed by the same clock? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 16, 2015 at 10:11 PM, Mark Rutland <mark.rutland@arm.com> wrote: > On Fri, Jan 16, 2015 at 12:53:16PM +0000, Lyra Zhang wrote: >> Hi, Mark >> >> >> + >> >> +Required properties: >> >> +- compatible: must be "sprd,sc9836-uart" >> >> +- reg: offset and length of the register set for the device >> >> +- interrupts: exactly one interrupt specifier >> >> +- clocks: phandles to input clocks. >> > >> > The order and relevance of each should be specified. If you have >> > multiple clocks I would strongly recommend you use clock-names to >> > distinguish them. >> > >> >> Thank you for the recommendation. >> but, since we haven't made the clock driver ready, for this initial >> commit, we just let 4 UARTs share a single fixed 26 MHz clock source. >> we'll do like you've recommended when we will submit the clock driver >> in the future. > > I'm on about the clock input lines on the UART instance, not the > providers they come from. > > Is there only a single clock input line on each UART? Perhaps multiple > input lines which are currently fed by the same clock?
diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt new file mode 100644 index 0000000..31a629d --- /dev/null +++ b/Documentation/devicetree/bindings/arm/sprd.txt @@ -0,0 +1,11 @@ +Spreadtrum SoC Platforms Device Tree Bindings +---------------------------------------------------- + +Sharkl64 is a Spreadtrum's SoC Platform which is based +on ARM 64-bit processor. + +SC9836 openphone board with SC9836 SoC based on the +Sharkl64 Platform shall have the following properties. + +Required root node properties: + - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt new file mode 100644 index 0000000..2aff0f2 --- /dev/null +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt @@ -0,0 +1,7 @@ +* Spreadtrum serial UART + +Required properties: +- compatible: must be "sprd,sc9836-uart" +- reg: offset and length of the register set for the device +- interrupts: exactly one interrupt specifier +- clocks: phandles to input clocks. diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index b1df0ad..0a8384f 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -153,6 +153,7 @@ snps Synopsys, Inc. solidrun SolidRun sony Sony Corporation spansion Spansion Inc. +sprd Spreadtrum Communications Inc. st STMicroelectronics ste ST-Ericsson stericsson ST-Ericsson