From patchwork Thu Jan 14 17:08:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Fix a typo in 'P' packet processing for M68K. Date: Thu, 14 Jan 2010 07:08:00 -0000 From: Kazu Hirata X-Patchwork-Id: 42920 Message-Id: <20100114170800.95B595664C4@henry1.codesourcery.com> To: qemu-devel@nongnu.org Cc: aurelien@aurel32.net Hi, Attached is a patch to fix a typo in 'P' packet processing for M68K. Without this patch, QEMU fails to honor GDB's P packets from GDB (writing to registers) for the address registers (A0 - A7). The problem is because of an obvious typo. Notice that the second "if" condition is meant to be n < 16 in: if (n < 8) { : } else if (n < 8) { Signed-off-by: Kazu Hirata --- gdbstub.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 6180171..80477be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1014,7 +1014,7 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n) if (n < 8) { /* D0-D7 */ env->dregs[n] = tmp; - } else if (n < 8) { + } else if (n < 16) { /* A0-A7 */ env->aregs[n - 8] = tmp; } else {