Patchwork [2.6] export genphy_restart_aneg

login
register
mail settings
Submitter Adrian Bunk
Date Oct. 13, 2008, 5:19 p.m.
Message ID <20081013171900.GK29938@cs181140183.pp.htv.fi>
Download mbox | patch
Permalink /patch/4292/
State Accepted
Commit 892871dcc39c23d3e30f8c317a5bfbab74084a40
Headers show

Comments

Adrian Bunk - Oct. 13, 2008, 5:19 p.m.
This patch fixes the following build error caused by
commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
(mv643xx_eth: convert to phylib):

<--  snip  -->

...
  Building modules, stage 2.
  MODPOST 1280 modules
ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
...
make[2]: *** [__modpost] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
Andy Fleming - Oct. 13, 2008, 6:04 p.m.
On Oct 13, 2008, at 12:19, Adrian Bunk wrote:

> This patch fixes the following build error caused by
> commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> (mv643xx_eth: convert to phylib):
>
> <--  snip  -->
>
> ...
>  Building modules, stage 2.
>  MODPOST 1280 modules
> ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <--  snip  -->
>
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>


Could you get genphy_setup_forced, too?  It doesn't appear to be used,  
but it's currently in include/linux/phy.h, and not static.

Alternatively, we could change genphy_setup_forced to be static.  :)

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 13, 2008, 6:52 p.m.
From: Andy Fleming <afleming@freescale.com>
Date: Mon, 13 Oct 2008 13:04:30 -0500

> 
> On Oct 13, 2008, at 12:19, Adrian Bunk wrote:
> 
> > This patch fixes the following build error caused by
> > commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> > (mv643xx_eth: convert to phylib):
> >
> > <--  snip  -->
> >
> > ...
> >  Building modules, stage 2.
> >  MODPOST 1280 modules
> > ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
> > ...
> > make[2]: *** [__modpost] Error 1
> >
> > <--  snip  -->
> >
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> 
> Could you get genphy_setup_forced, too?  It doesn't appear to be used, but it's currently in include/linux/phy.h, and not static.

When there is a use we can add the export.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 14, 2008, 1:48 a.m.
From: Adrian Bunk <bunk@kernel.org>
Date: Mon, 13 Oct 2008 20:19:00 +0300

> This patch fixes the following build error caused by
> commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> (mv643xx_eth: convert to phylib):

Applied, th anks Adrian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 1716274..f11e900 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -557,6 +557,7 @@  int genphy_restart_aneg(struct phy_device *phydev)
 
 	return ctl;
 }
+EXPORT_SYMBOL(genphy_restart_aneg);
 
 
 /**