Patchwork char: Remove redundant qemu_chr_generic_open() call.

login
register
mail settings
Submitter Kusanagi Kouichi
Date Jan. 14, 2010, 3:46 p.m.
Message ID <20100114154625.732C062C03A@msa106.auone-net.jp>
Download mbox | patch
Permalink /patch/42899/
State New
Headers show

Comments

Kusanagi Kouichi - Jan. 14, 2010, 3:46 p.m.
qemu_chr_open_fd() calls qemu_chr_generic_open(),
so qemu_chr_open_tty() doesn't need to call it.

Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
---
 qemu-char.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Anthony Liguori - Jan. 19, 2010, 10:38 p.m.
On 01/14/2010 09:46 AM, Kusanagi Kouichi wrote:
> qemu_chr_open_fd() calls qemu_chr_generic_open(),
> so qemu_chr_open_tty() doesn't need to call it.
>
> Signed-off-by: Kusanagi Kouichi<slash@ac.auone-net.jp>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   qemu-char.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index b13f8d4..800ee6c 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1187,7 +1187,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>           return NULL;
>       }
>       chr->chr_ioctl = tty_serial_ioctl;
> -    qemu_chr_generic_open(chr);
>       return chr;
>   }
>   #else  /* ! __linux__&&  ! __sun__ */
>

Patch

diff --git a/qemu-char.c b/qemu-char.c
index b13f8d4..800ee6c 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1187,7 +1187,6 @@  static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
         return NULL;
     }
     chr->chr_ioctl = tty_serial_ioctl;
-    qemu_chr_generic_open(chr);
     return chr;
 }
 #else  /* ! __linux__ && ! __sun__ */