Message ID | 1421191022-5509-3-git-send-email-gustavo@zacarias.com.ar |
---|---|
State | Accepted |
Headers | show |
Dear Gustavo Zacarias, On Tue, 13 Jan 2015 20:16:58 -0300, Gustavo Zacarias wrote: > Do it to avoid having duplicate and conflicting functionality with > busybox's S01logging. > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/rsyslog/{S01rsyslog => S01logging} | 0 > package/rsyslog/rsyslog.mk | 4 ++-- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename package/rsyslog/{S01rsyslog => S01logging} (100%) To be honest, I wasn't really sure whether the right approach to handle this issue was to rename the init script as you did, or to have rsyslog explicitly remove S01logging when Busybox is enabled. Since the rest of patch series was doing some cleanup on the renamed S01logging, I decided to take your approach, but I must say I wasn't entirely sure on how to handle this. Comments from others are welcome, I don't consider the proposed solution to be set in stone. Thomas
On 01/14/2015 04:30 PM, Thomas Petazzoni wrote: > To be honest, I wasn't really sure whether the right approach to handle > this issue was to rename the init script as you did, or to have rsyslog > explicitly remove S01logging when Busybox is enabled. > > Since the rest of patch series was doing some cleanup on the renamed > S01logging, I decided to take your approach, but I must say I wasn't > entirely sure on how to handle this. > > Comments from others are welcome, I don't consider the proposed > solution to be set in stone. It's the best deterministic option we've got, rsyslog builds after busybox (famous dependency trickery) but then again there's no clear winner with sysklogd (the default shell dilemma). We could throw an option for logger, but i think that would be crowding things a little. I'm not opposed to it or other solutions though. Regards.
Dear Gustavo Zacarias, On Wed, 14 Jan 2015 16:33:58 -0300, Gustavo Zacarias wrote: > > Comments from others are welcome, I don't consider the proposed > > solution to be set in stone. > > It's the best deterministic option we've got, rsyslog builds after > busybox (famous dependency trickery) but then again there's no clear > winner with sysklogd (the default shell dilemma). > We could throw an option for logger, but i think that would be crowding > things a little. > I'm not opposed to it or other solutions though. Yeah, I agree, there's no immediately perfect solution that comes to mind. Maybe we don't want to handle too much of these issues, and leave it to the user to realize that building both rsyslog and syslogd is stupid. Thomas
diff --git a/package/rsyslog/S01rsyslog b/package/rsyslog/S01logging similarity index 100% rename from package/rsyslog/S01rsyslog rename to package/rsyslog/S01logging diff --git a/package/rsyslog/rsyslog.mk b/package/rsyslog/rsyslog.mk index 688a335..27a72da 100644 --- a/package/rsyslog/rsyslog.mk +++ b/package/rsyslog/rsyslog.mk @@ -39,8 +39,8 @@ else endif define RSYSLOG_INSTALL_INIT_SYSV - $(INSTALL) -m 0755 -D package/rsyslog/S01rsyslog \ - $(TARGET_DIR)/etc/init.d/S01rsyslog + $(INSTALL) -m 0755 -D package/rsyslog/S01logging \ + $(TARGET_DIR)/etc/init.d/S01logging endef define RSYSLOG_INSTALL_INIT_SYSTEMD
Do it to avoid having duplicate and conflicting functionality with busybox's S01logging. Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/rsyslog/{S01rsyslog => S01logging} | 0 package/rsyslog/rsyslog.mk | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) rename package/rsyslog/{S01rsyslog => S01logging} (100%)