From patchwork Tue Jan 12 19:34:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ide/ide-cs: fix order of releasing resources Date: Tue, 12 Jan 2010 09:34:54 -0000 From: Wolfram Sang X-Patchwork-Id: 42747 Message-Id: <1263324894-28117-1-git-send-email-w.sang@pengutronix.de> To: linux-ide@vger.kernel.org Cc: linux-pcmcia@lists.infradead.org, Wolfram Sang , Dominik Brodowski , Bartlomiej Zolnierkiewicz , "David S. Miller" ide_detach() called first ide_release() and then release_region(). This produced the following warnings: Trying to free nonexistent resource <000000000000c10e-000000000000c10e> Trying to free nonexistent resource <000000000000c100-000000000000c107> This is true, because the callchain inside ide_release() is: ide_release -> pcmcia_disable_device -> pcmcia_release_io So, the whole io-block is already gone for release_region(). To fix this, just swap the order of releasing (and remove the now obsolete shadowing). Signed-off-by: Wolfram Sang Cc: Dominik Brodowski Cc: Bartlomiej Zolnierkiewicz Cc: "David S. Miller" Acked-by: Dominik Brodowski --- drivers/ide/ide-cs.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/ide/ide-cs.c b/drivers/ide/ide-cs.c index dd63963..43ed330 100644 --- a/drivers/ide/ide-cs.c +++ b/drivers/ide/ide-cs.c @@ -122,18 +122,14 @@ static void ide_detach(struct pcmcia_device *link) { ide_info_t *info = link->priv; ide_hwif_t *hwif = info->host->ports[0]; - unsigned long data_addr, ctl_addr; dev_dbg(&link->dev, "ide_detach(0x%p)\n", link); - data_addr = hwif->io_ports.data_addr; - ctl_addr = hwif->io_ports.ctl_addr; + release_region(hwif->io_ports.ctl_addr, 1); + release_region(hwif->io_ports.data_addr, 8); ide_release(link); - release_region(ctl_addr, 1); - release_region(data_addr, 8); - kfree(info); } /* ide_detach */