diff mbox

[4/4] ARM: tegra: fix big-endian issue with irq code

Message ID 1420817231-8346-5-git-send-email-bob.mottram@codethink.co.uk
State Accepted, archived
Headers show

Commit Message

Bob Mottram Jan. 9, 2015, 3:27 p.m. UTC
Replace the _raw-writel with writel_relaxed to fix issue with
running tegra in big-endian. Tested on Jetson TK1.

Signed-off-by: Bob Mottram <bob.mottram@codethink.co.uk>
---
 arch/arm/mach-tegra/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Dmitry Osipenko Jan. 27, 2015, 6:42 p.m. UTC | #1
09.01.2015 18:27, Bob Mottram пишет:
> Replace the _raw-writel with writel_relaxed to fix issue with
> running tegra in big-endian. Tested on Jetson TK1.
>
> Signed-off-by: Bob Mottram <bob.mottram@codethink.co.uk>
> ---
>   arch/arm/mach-tegra/irq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c
> index ab95f53..f4c2857 100644
> --- a/arch/arm/mach-tegra/irq.c
> +++ b/arch/arm/mach-tegra/irq.c
> @@ -94,7 +94,7 @@ static inline void tegra_irq_write_mask(unsigned int irq, unsigned long reg)
>   	base = ictlr_reg_base[(irq - FIRST_LEGACY_IRQ) / 32];
>   	mask = BIT((irq - FIRST_LEGACY_IRQ) % 32);
>
> -	__raw_writel(mask, base + reg);
> +	writel_relaxed(mask, base + reg);
>   }
>
>   static void tegra_mask(struct irq_data *d)
> --
> 2.1.0
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Thierry Reding March 11, 2015, 9:48 a.m. UTC | #2
On Fri, Jan 09, 2015 at 03:27:11PM +0000, Bob Mottram wrote:
> Replace the _raw-writel with writel_relaxed to fix issue with
> running tegra in big-endian. Tested on Jetson TK1.
> 
> Signed-off-by: Bob Mottram <bob.mottram@codethink.co.uk>
> ---
>  arch/arm/mach-tegra/irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry
diff mbox

Patch

diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c
index ab95f53..f4c2857 100644
--- a/arch/arm/mach-tegra/irq.c
+++ b/arch/arm/mach-tegra/irq.c
@@ -94,7 +94,7 @@  static inline void tegra_irq_write_mask(unsigned int irq, unsigned long reg)
 	base = ictlr_reg_base[(irq - FIRST_LEGACY_IRQ) / 32];
 	mask = BIT((irq - FIRST_LEGACY_IRQ) % 32);

-	__raw_writel(mask, base + reg);
+	writel_relaxed(mask, base + reg);
 }

 static void tegra_mask(struct irq_data *d)