@@ -998,18 +998,6 @@ err_id_free:
*
*****************************************************************************/
-static void hex_dump(const unsigned char *buf, size_t len)
-{
- size_t i;
-
- for (i = 0; i < len; i++) {
- if (i && !(i % 16))
- printk("\n");
- printk("%02x ", *(buf + i));
- }
- printk("\n");
-}
-
/*
* Parse and mangle SNMP message according to mapping.
* (And this is the fucking 'basic' method).
@@ -1026,7 +1014,7 @@ static int snmp_parse_mangle(unsigned char *msg,
struct snmp_object *obj;
if (debug > 1)
- hex_dump(msg, len);
+ print_hex_dump_bytes("", DUMP_PREFIX_NONE, msg, len);
asn1_open(&ctx, msg, len);
Use the generic facility instead of a static hex_dump routine. Delete the now unused static routine. Now emits the hex dump at KERN_DEBUG instead of default. Shrinks the kernel ever so trivially. $ size net/ipv4/netfilter/nf_nat_snmp_basic.o* text data bss dec hex filename 5948 352 8 6308 18a4 net/ipv4/netfilter/nf_nat_snmp_basic.o.defconfig.new 5985 352 8 6345 18c9 net/ipv4/netfilter/nf_nat_snmp_basic.o.defconfig.old Signed-off-by: Joe Perches <joe@perches.com> --- net/ipv4/netfilter/nf_nat_snmp_basic.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html