| Message ID | 1420684386-5975-17-git-send-email-jiang.liu@linux.intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, 8 Jan 2015, Jiang Liu wrote: > Introduce helper function acpi_dev_filter_resource_type(), which may > be used by acpi_dev_get_resources() to filer out resource based on > resource type. > > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> > --- > drivers/acpi/resource.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/acpi.h | 1 + > 2 files changed, 55 insertions(+) > > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > index 54204ac94f8e..8ea7c26d6915 100644 > --- a/drivers/acpi/resource.c > +++ b/drivers/acpi/resource.c > @@ -570,3 +570,57 @@ int acpi_dev_get_resources(struct acpi_device *adev, struct list_head *list, > return c.count; > } > EXPORT_SYMBOL_GPL(acpi_dev_get_resources); > + > +/** > + * acpi_dev_filter_resource_type - Filter ACPI resource according to resource > + * types > + * @ares: Input ACPI resource object. > + * @arg: Valid resource types of IORESOURCE_XXX > + * > + * This is a hepler function to support acpi_dev_get_resources(), which filters > + * ACPI resource objects according to resource types. > + */ > +int acpi_dev_filter_resource_type(struct acpi_resource *ares, void *arg) Why is the filter a void pointer instead of an simple unsigned long? That does not make any sense as you convert it to unsigned long right away: > +{ > + unsigned long type = 0, types = (unsigned long)arg; So this should be: int acpi_dev_filter_resource_type(struct acpi_resource *ares, unsigned long type_mask) or something like that. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015/1/16 5:30, Thomas Gleixner wrote: > On Thu, 8 Jan 2015, Jiang Liu wrote: > >> Introduce helper function acpi_dev_filter_resource_type(), which may >> be used by acpi_dev_get_resources() to filer out resource based on >> resource type. >> >> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> >> --- >> drivers/acpi/resource.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/acpi.h | 1 + >> 2 files changed, 55 insertions(+) >> >> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c >> index 54204ac94f8e..8ea7c26d6915 100644 >> --- a/drivers/acpi/resource.c >> +++ b/drivers/acpi/resource.c >> @@ -570,3 +570,57 @@ int acpi_dev_get_resources(struct acpi_device *adev, struct list_head *list, >> return c.count; >> } >> EXPORT_SYMBOL_GPL(acpi_dev_get_resources); >> + >> +/** >> + * acpi_dev_filter_resource_type - Filter ACPI resource according to resource >> + * types >> + * @ares: Input ACPI resource object. >> + * @arg: Valid resource types of IORESOURCE_XXX >> + * >> + * This is a hepler function to support acpi_dev_get_resources(), which filters >> + * ACPI resource objects according to resource types. >> + */ >> +int acpi_dev_filter_resource_type(struct acpi_resource *ares, void *arg) > > Why is the filter a void pointer instead of an simple unsigned long? > That does not make any sense as you convert it to unsigned long right away: > >> +{ >> + unsigned long type = 0, types = (unsigned long)arg; > > So this should be: > > int acpi_dev_filter_resource_type(struct acpi_resource *ares, unsigned long type_mask) > > or something like that. Hi Thomas, I used void * instead of unsigned long for type_mask so acpi_dev_filter_resource_type() could directly used by acpi_dev_get_resources(). Otherwise we need to use something like acpi_dev_get_resources(..., (void *)acpi_dev_filter_resource_type, ...). I will find a way to solve this:) Regards! Gerry > > Thanks, > > tglx > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 54204ac94f8e..8ea7c26d6915 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -570,3 +570,57 @@ int acpi_dev_get_resources(struct acpi_device *adev, struct list_head *list, return c.count; } EXPORT_SYMBOL_GPL(acpi_dev_get_resources); + +/** + * acpi_dev_filter_resource_type - Filter ACPI resource according to resource + * types + * @ares: Input ACPI resource object. + * @arg: Valid resource types of IORESOURCE_XXX + * + * This is a hepler function to support acpi_dev_get_resources(), which filters + * ACPI resource objects according to resource types. + */ +int acpi_dev_filter_resource_type(struct acpi_resource *ares, void *arg) +{ + unsigned long type = 0, types = (unsigned long)arg; + + switch (ares->type) { + case ACPI_RESOURCE_TYPE_MEMORY24: + case ACPI_RESOURCE_TYPE_MEMORY32: + case ACPI_RESOURCE_TYPE_FIXED_MEMORY32: + type = IORESOURCE_MEM; + break; + case ACPI_RESOURCE_TYPE_IO: + case ACPI_RESOURCE_TYPE_FIXED_IO: + type = IORESOURCE_IO; + break; + case ACPI_RESOURCE_TYPE_IRQ: + case ACPI_RESOURCE_TYPE_EXTENDED_IRQ: + type = IORESOURCE_IRQ; + break; + case ACPI_RESOURCE_TYPE_DMA: + case ACPI_RESOURCE_TYPE_FIXED_DMA: + type = IORESOURCE_DMA; + break; + case ACPI_RESOURCE_TYPE_GENERIC_REGISTER: + type = IORESOURCE_REG; + break; + case ACPI_RESOURCE_TYPE_ADDRESS16: + case ACPI_RESOURCE_TYPE_ADDRESS32: + case ACPI_RESOURCE_TYPE_ADDRESS64: + case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64: + if (ares->data.address.resource_type == ACPI_MEMORY_RANGE) + type = IORESOURCE_MEM; + else if (ares->data.address.resource_type == ACPI_IO_RANGE) + type = IORESOURCE_IO; + else if (ares->data.address.resource_type == + ACPI_BUS_NUMBER_RANGE) + type = IORESOURCE_BUS; + break; + default: + break; + } + + return (type & types) ? 0 : 1; +} +EXPORT_SYMBOL_GPL(acpi_dev_filter_resource_type); diff --git a/include/linux/acpi.h b/include/linux/acpi.h index fea78e772450..1df4a0211ae5 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -307,6 +307,7 @@ void acpi_dev_free_resource_list(struct list_head *list); int acpi_dev_get_resources(struct acpi_device *adev, struct list_head *list, int (*preproc)(struct acpi_resource *, void *), void *preproc_data); +int acpi_dev_filter_resource_type(struct acpi_resource *ares, void *arg); int acpi_check_resource_conflict(const struct resource *res);
Introduce helper function acpi_dev_filter_resource_type(), which may be used by acpi_dev_get_resources() to filer out resource based on resource type. Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> --- drivers/acpi/resource.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++ include/linux/acpi.h | 1 + 2 files changed, 55 insertions(+)