Message ID | 1420679180-14883-10-git-send-email-tangchen@cn.fujitsu.com |
---|---|
State | New |
Headers | show |
On Thu, 8 Jan 2015 09:06:16 +0800 Tang Chen <tangchen@cn.fujitsu.com> wrote: > Call memory unplug cb in piix4_device_unplug_cb(). > --- > hw/acpi/piix4.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index f809c3a..4ae4867 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -377,8 +377,16 @@ static void piix4_device_unplug_request_cb(HotplugHandler *hotplug_dev, > static void piix4_device_unplug_cb(HotplugHandler *hotplug_dev, > DeviceState *dev, Error **errp) > { > - error_setg(errp, "acpi: device unplug for not supported device" > - " type: %s", object_get_typename(OBJECT(dev))); > + PIIX4PMState *s = PIIX4_PM(hotplug_dev); > + > + if (s->acpi_memory_hotplug.is_enabled && is above check really necessary? If yes, do it inside common acpi_memory_unplug_cb() > + object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { > + acpi_memory_unplug_cb(&s->ar, s->irq, &s->acpi_memory_hotplug, > + dev, errp); > + } else { > + error_setg(errp, "acpi: device unplug for not supported device" > + " type: %s", object_get_typename(OBJECT(dev))); > + } > } > > static void piix4_update_bus_hotplug(PCIBus *pci_bus, void *opaque)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index f809c3a..4ae4867 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -377,8 +377,16 @@ static void piix4_device_unplug_request_cb(HotplugHandler *hotplug_dev, static void piix4_device_unplug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp) { - error_setg(errp, "acpi: device unplug for not supported device" - " type: %s", object_get_typename(OBJECT(dev))); + PIIX4PMState *s = PIIX4_PM(hotplug_dev); + + if (s->acpi_memory_hotplug.is_enabled && + object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { + acpi_memory_unplug_cb(&s->ar, s->irq, &s->acpi_memory_hotplug, + dev, errp); + } else { + error_setg(errp, "acpi: device unplug for not supported device" + " type: %s", object_get_typename(OBJECT(dev))); + } } static void piix4_update_bus_hotplug(PCIBus *pci_bus, void *opaque)