| Message ID | 1420621722-7428-4-git-send-email-oliver+list@schinagl.nl |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 07, 2015 at 10:08:41AM +0100, Olliver Schinagl wrote: > From: Olliver Schinagl <oliver@schinagl.nl> > > In the gpio bindings documents it is requested to use the marco's in > include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led > drivers don't seem to form an exception, so update the example in the > document bindings. > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > --- > Documentation/devicetree/bindings/leds/leds-gpio.txt | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt > index f77148f..d544cf1 100644 > --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt > +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt > @@ -26,16 +26,18 @@ LED sub-node properties: > > Examples: > > +#include <dt-bindings/gpio/gpio.h> > + > leds { > compatible = "gpio-leds"; > hdd { > label = "IDE Activity"; > - gpios = <&mcu_pio 0 1>; /* Active low */ > + gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>; > linux,default-trigger = "ide-disk"; > }; > > fault { > - gpios = <&mcu_pio 1 0>; > + gpios = <&mcu_pio 1 GPIO_ACTIVE_HIGH>; > /* Keep LED on if BIOS detected hardware fault */ > default-state = "keep"; > }; > @@ -44,11 +46,11 @@ leds { > run-control { > compatible = "gpio-leds"; > red { > - gpios = <&mpc8572 6 0>; > + gpios = <&mpc8572 6 GPIO_ACTIVE_HIHG>; Typo, s/HIHG/HIGH/ > default-state = "off"; > }; > green { > - gpios = <&mpc8572 7 0>; > + gpios = <&mpc8572 7 GPIO_ACTIVE_HIGH>; > default-state = "on"; > }; > }; > @@ -57,7 +59,7 @@ leds { > compatible = "gpio-leds"; > > charger-led { > - gpios = <&gpio1 2 0>; > + gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "max8903-charger-charging"; > retain-state-suspended; > }; > -- > 2.1.4 >
On Wed, Jan 7, 2015 at 3:08 AM, Olliver Schinagl <oliver+list@schinagl.nl> wrote: > From: Olliver Schinagl <oliver@schinagl.nl> > > In the gpio bindings documents it is requested to use the marco's in > include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led > drivers don't seem to form an exception, so update the example in the > document bindings. > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> The example isn't exactly wrong, so I'd question how much this is really needed, but: Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/leds/leds-gpio.txt | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt > index f77148f..d544cf1 100644 > --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt > +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt > @@ -26,16 +26,18 @@ LED sub-node properties: > > Examples: > > +#include <dt-bindings/gpio/gpio.h> > + > leds { > compatible = "gpio-leds"; > hdd { > label = "IDE Activity"; > - gpios = <&mcu_pio 0 1>; /* Active low */ > + gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>; > linux,default-trigger = "ide-disk"; > }; > > fault { > - gpios = <&mcu_pio 1 0>; > + gpios = <&mcu_pio 1 GPIO_ACTIVE_HIGH>; > /* Keep LED on if BIOS detected hardware fault */ > default-state = "keep"; > }; > @@ -44,11 +46,11 @@ leds { > run-control { > compatible = "gpio-leds"; > red { > - gpios = <&mpc8572 6 0>; > + gpios = <&mpc8572 6 GPIO_ACTIVE_HIHG>; > default-state = "off"; > }; > green { > - gpios = <&mpc8572 7 0>; > + gpios = <&mpc8572 7 GPIO_ACTIVE_HIGH>; > default-state = "on"; > }; > }; > @@ -57,7 +59,7 @@ leds { > compatible = "gpio-leds"; > > charger-led { > - gpios = <&gpio1 2 0>; > + gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "max8903-charger-charging"; > retain-state-suspended; > }; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 7, 2015 at 10:08 AM, Olliver Schinagl <oliver+list@schinagl.nl> wrote: > From: Olliver Schinagl <oliver@schinagl.nl> > > In the gpio bindings documents it is requested to use the marco's in > include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led > drivers don't seem to form an exception, so update the example in the > document bindings. > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> With the spelling mistake fixed: Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt index f77148f..d544cf1 100644 --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt @@ -26,16 +26,18 @@ LED sub-node properties: Examples: +#include <dt-bindings/gpio/gpio.h> + leds { compatible = "gpio-leds"; hdd { label = "IDE Activity"; - gpios = <&mcu_pio 0 1>; /* Active low */ + gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>; linux,default-trigger = "ide-disk"; }; fault { - gpios = <&mcu_pio 1 0>; + gpios = <&mcu_pio 1 GPIO_ACTIVE_HIGH>; /* Keep LED on if BIOS detected hardware fault */ default-state = "keep"; }; @@ -44,11 +46,11 @@ leds { run-control { compatible = "gpio-leds"; red { - gpios = <&mpc8572 6 0>; + gpios = <&mpc8572 6 GPIO_ACTIVE_HIHG>; default-state = "off"; }; green { - gpios = <&mpc8572 7 0>; + gpios = <&mpc8572 7 GPIO_ACTIVE_HIGH>; default-state = "on"; }; }; @@ -57,7 +59,7 @@ leds { compatible = "gpio-leds"; charger-led { - gpios = <&gpio1 2 0>; + gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; linux,default-trigger = "max8903-charger-charging"; retain-state-suspended; };