Patchwork [#upstream-fixes] ata_piix: enable 32bit PIO on SATA piix

login
register
mail settings
Submitter Tejun Heo
Date Jan. 11, 2010, 8:03 a.m.
Message ID <4B4ADB3F.2080505@kernel.org>
Download mbox | patch
Permalink /patch/42592/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - Jan. 11, 2010, 8:03 a.m.
Commit 871af1210f13966ab911ed2166e4ab2ce775b99d enabled 32bit PIO for
PATA piix but didn't for SATA.  There's no reason not to use 32bit PIO
on SATA piix.  Enable it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
 drivers/ata/ata_piix.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Jan. 12, 2010, 7:38 p.m.
On 01/11/2010 03:03 AM, Tejun Heo wrote:
> Commit 871af1210f13966ab911ed2166e4ab2ce775b99d enabled 32bit PIO for
> PATA piix but didn't for SATA.  There's no reason not to use 32bit PIO
> on SATA piix.  Enable it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: Alan Cox<alan@lxorguk.ukuu.org.uk>
> ---
>   drivers/ata/ata_piix.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: ata/drivers/ata/ata_piix.c
> ===================================================================
> --- ata.orig/drivers/ata/ata_piix.c
> +++ ata/drivers/ata/ata_piix.c
> @@ -329,7 +329,7 @@ static struct ata_port_operations ich_pa
>   };
>
>   static struct ata_port_operations piix_sata_ops = {
> -	.inherits		=&ata_bmdma_port_ops,
> +	.inherits		=&ata_bmdma32_port_ops,
>   };

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: ata/drivers/ata/ata_piix.c
===================================================================
--- ata.orig/drivers/ata/ata_piix.c
+++ ata/drivers/ata/ata_piix.c
@@ -329,7 +329,7 @@  static struct ata_port_operations ich_pa
 };
 
 static struct ata_port_operations piix_sata_ops = {
-	.inherits		= &ata_bmdma_port_ops,
+	.inherits		= &ata_bmdma32_port_ops,
 };
 
 static struct ata_port_operations piix_sidpr_sata_ops = {