| Message ID | 54AC2039.4020203@suse.cz |
|---|---|
| State | New |
| Headers | show |
On Tue, Jan 6, 2015 at 6:49 PM, Martin Liška <mliska@suse.cz> wrote: > Hello. > > There's suggested patch for PR ipa/64503 that was tested on x86_64 and it > works. > I would like to ask Uros to test it on an aplha machine before we install > the patch. Yes, this works for me on all IPA tests that were failing previously [1]. I am restarting the bootstrap + regtest, it will take ~10 hours, but I don't expect any surprises there. [1] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00400.html Thanks, Uros.
On Tue, Jan 6, 2015 at 7:25 PM, Uros Bizjak <ubizjak@gmail.com> wrote: >> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it >> works. >> I would like to ask Uros to test it on an aplha machine before we install >> the patch. > > Yes, this works for me on all IPA tests that were failing previously [1]. > > I am restarting the bootstrap + regtest, it will take ~10 hours, but I > don't expect any surprises there. The patch was bootstrapped and regression tested on alphaev68-linux-gnu [2] and everything was OK. [2] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00577.html Thanks, Uros.
On 01/07/2015 11:55 AM, Uros Bizjak wrote: > On Tue, Jan 6, 2015 at 7:25 PM, Uros Bizjak <ubizjak@gmail.com> wrote: > >>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it >>> works. >>> I would like to ask Uros to test it on an aplha machine before we install >>> the patch. >> >> Yes, this works for me on all IPA tests that were failing previously [1]. >> >> I am restarting the bootstrap + regtest, it will take ~10 hours, but I >> don't expect any surprises there. > > The patch was bootstrapped and regression tested on > alphaev68-linux-gnu [2] and everything was OK. Hi. Thanks for testing. May I take this as approval of the patch. I don't know, if you have a permission to accept my patch ;) Thanks, Martin > > [2] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00577.html > > Thanks, > Uros. >
On 01/07/15 03:55, Uros Bizjak wrote: > On Tue, Jan 6, 2015 at 7:25 PM, Uros Bizjak <ubizjak@gmail.com> wrote: > >>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it >>> works. >>> I would like to ask Uros to test it on an aplha machine before we install >>> the patch. >> >> Yes, this works for me on all IPA tests that were failing previously [1]. >> >> I am restarting the bootstrap + regtest, it will take ~10 hours, but I >> don't expect any surprises there. > > The patch was bootstrapped and regression tested on > alphaev68-linux-gnu [2] and everything was OK. > > [2] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00577.html I'll approve the patch. scalbln is part of the ISO C standard as well as IEEE 1003.1, so I think we can rely on it. If there's a host without, then we'll have to figure something out if/when the issue is reported. jeff
From d4738c61467e53d04b295cfc029ab89707ac29ce Mon Sep 17 00:00:00 2001 From: mliska <mliska@suse.cz> Date: Tue, 6 Jan 2015 12:25:51 +0100 Subject: [PATCH] Fix for ipa/PR64503 gcc/ChangeLog: 2015-01-06 Martin Liska <mliska@suse.cz> PR ipa/64503 * sreal.c (sreal::dump): Change unsigned format to signed for m_exp value. (sreal::to_double): Replace exp2 with scalbln. --- gcc/sreal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/sreal.c b/gcc/sreal.c index 82ebcb8..622fc2d 100644 --- a/gcc/sreal.c +++ b/gcc/sreal.c @@ -58,7 +58,7 @@ along with GCC; see the file COPYING3. If not see void sreal::dump (FILE *file) const { - fprintf (file, "(%" PRIu64 " * 2^%d)", m_sig, m_exp); + fprintf (file, "(%" PRIi64 " * 2^%d)", m_sig, m_exp); } DEBUG_FUNCTION void @@ -122,7 +122,7 @@ sreal::to_double () const { double val = m_sig; if (m_exp) - val *= exp2 (m_exp); + val = scalbln (val, m_exp); return val; } -- 2.1.2