| Message ID | 1420552994-657-7-git-send-email-johan.oudinet@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Johan Oudinet, On Tue, 6 Jan 2015 15:03:04 +0100, Johan Oudinet wrote: > Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> That many SoB lines? :-) > diff --git a/package/erlang-p1-zlib/Config.in b/package/erlang-p1-zlib/Config.in > new file mode 100644 > index 0000000..583d856 > --- /dev/null > +++ b/package/erlang-p1-zlib/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_ERLANG_P1_ZLIB > + bool "erlang-p1-zlib" Are you sure you shouldn't select BR2_PACKAGE_ZLIB here. > +ERLANG_P1_ZLIB_VERSION = 52e82bb > +ERLANG_P1_ZLIB_SITE = $(call github,processone,zlib,$(ERLANG_P1_ZLIB_VERSION)) > +ERLANG_P1_ZLIB_LICENSE = GPLv2+ > +ERLANG_P1_ZLIB_LICENSE_FILES = COPYING and depend on zlib here? Thomas
Johan, All, On 2015-01-10 16:45 +0100, Thomas Petazzoni spake thusly: > Dear Johan Oudinet, > > On Tue, 6 Jan 2015 15:03:04 +0100, Johan Oudinet wrote: > > Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > > Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > > Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> > > That many SoB lines? :-) Hehe! :-) "pwclient git-am" asks git am to add a SoB-line, which does not verify if it is already present or not. Unfortunate... :-/ Regards, Yann E. MORIN.
Thomas, All, On Sat, Jan 10, 2015 at 4:45 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > On Tue, 6 Jan 2015 15:03:04 +0100, Johan Oudinet wrote: >> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> >> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> >> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> >> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> >> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com> > > That many SoB lines? :-) I'll remove them by hand and keep only one of each. > >> diff --git a/package/erlang-p1-zlib/Config.in b/package/erlang-p1-zlib/Config.in >> new file mode 100644 >> index 0000000..583d856 >> --- /dev/null >> +++ b/package/erlang-p1-zlib/Config.in >> @@ -0,0 +1,6 @@ >> +config BR2_PACKAGE_ERLANG_P1_ZLIB >> + bool "erlang-p1-zlib" > > Are you sure you shouldn't select BR2_PACKAGE_ZLIB here. > >> +ERLANG_P1_ZLIB_VERSION = 52e82bb >> +ERLANG_P1_ZLIB_SITE = $(call github,processone,zlib,$(ERLANG_P1_ZLIB_VERSION)) >> +ERLANG_P1_ZLIB_LICENSE = GPLv2+ >> +ERLANG_P1_ZLIB_LICENSE_FILES = COPYING > > and depend on zlib here? Indeed, there is an AC_CHECK_HEADER(zlib.h) in the configure.ac. I'll add the dependency to zlib. Thanks.
diff --git a/package/Config.in b/package/Config.in index 6db6c5c..038147f 100644 --- a/package/Config.in +++ b/package/Config.in @@ -399,6 +399,7 @@ if BR2_PACKAGE_ERLANG menu "Erlang libraries/modules" source "package/erlang-goldrush/Config.in" source "package/erlang-lager/Config.in" + source "package/erlang-p1-zlib/Config.in" endmenu endif source "package/guile/Config.in" diff --git a/package/erlang-p1-zlib/Config.in b/package/erlang-p1-zlib/Config.in new file mode 100644 index 0000000..583d856 --- /dev/null +++ b/package/erlang-p1-zlib/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_ERLANG_P1_ZLIB + bool "erlang-p1-zlib" + help + Erlang interface to zlib + + https://github.com/processone/zlib diff --git a/package/erlang-p1-zlib/erlang-p1-zlib.mk b/package/erlang-p1-zlib/erlang-p1-zlib.mk new file mode 100644 index 0000000..ae95cb4 --- /dev/null +++ b/package/erlang-p1-zlib/erlang-p1-zlib.mk @@ -0,0 +1,12 @@ +################################################################################ +# +# erlang-p1-zlib +# +################################################################################ + +ERLANG_P1_ZLIB_VERSION = 52e82bb +ERLANG_P1_ZLIB_SITE = $(call github,processone,zlib,$(ERLANG_P1_ZLIB_VERSION)) +ERLANG_P1_ZLIB_LICENSE = GPLv2+ +ERLANG_P1_ZLIB_LICENSE_FILES = COPYING + +$(eval $(rebar-package))