| Message ID | alpine.DEB.2.00.1001091420080.21892@ayla.of.borg |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Sat, 9 Jan 2010 14:21:28 +0100 (CET) > commit 18c0019102228875cb0f6f252dad5148491e96b2 ("drivers/net/mac8390.c: > Convert printk(KERN_<level> to pr_<level>(") broke the build: > > | drivers/net/mac8390.c:306: error: expected ')' before 'version' > > as "version" is not a string literal, but a variable. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c index c70bd68..a876867 100644 --- a/drivers/net/mac8390.c +++ b/drivers/net/mac8390.c @@ -303,7 +303,7 @@ static bool __init mac8390_init(struct net_device *dev, struct nubus_dev *ndev, int offset; volatile unsigned short *i; - printk_once(KERN_INFO pr_fmt(version)); + printk_once(KERN_INFO pr_fmt("%s"), version); dev->irq = SLOT2IRQ(ndev->board->slot); /* This is getting to be a habit */
commit 18c0019102228875cb0f6f252dad5148491e96b2 ("drivers/net/mac8390.c: Convert printk(KERN_<level> to pr_<level>(") broke the build: | drivers/net/mac8390.c:306: error: expected ')' before 'version' as "version" is not a string literal, but a variable. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- http://kisskb.ellerman.id.au/kisskb/buildresult/1985016/ drivers/net/mac8390.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)