| Message ID | 1420477207-14637-1-git-send-email-yegorslists@googlemail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear Yegor Yefremov, On Mon, 5 Jan 2015 18:00:07 +0100, Yegor Yefremov wrote: > diff --git a/package/python-tornado/Config.in b/package/python-tornado/Config.in > index 870a3de..9bbfc55 100644 > --- a/package/python-tornado/Config.in > +++ b/package/python-tornado/Config.in > @@ -1,7 +1,10 @@ > config BR2_PACKAGE_PYTHON_TORNADO > bool "python-tornado" > - depends on BR2_PACKAGE_PYTHON > - select BR2_PACKAGE_PYTHON_ZLIB > + select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime > + select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3 # runtime > + select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime > + select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime > + select BR2_PACKAGE_PYTHON_CERTIFI # runtime Are you sure SSL and certifi are mandatory dependencies? I see the following things in the source code: try: import ssl except ImportError: # ssl is not available on Google App Engine. ssl = None try: import certifi except ImportError: certifi = None Which seem to indicate that those Python packages are not mandatory for python-tornado. They are only needed if you want to do https:// connexions, no? > +# Locally computed: > +sha1 6152ea61b4cdf9566f3974f30603ff51b527dd87 tornado-4.0.2.tar.gz > +sha256 900c5124ebdb6598ca8e8a0c5888f41a5f14117952d5515258e3d20222b21bfa tornado-4.0.2.tar.gz sha256 is sufficient, no need to have sha1 in addition to it. Could you look at the dependency issue above? Thanks! Thomas
On Tue, Jan 6, 2015 at 10:01 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Yegor Yefremov, > > On Mon, 5 Jan 2015 18:00:07 +0100, Yegor Yefremov wrote: > >> diff --git a/package/python-tornado/Config.in b/package/python-tornado/Config.in >> index 870a3de..9bbfc55 100644 >> --- a/package/python-tornado/Config.in >> +++ b/package/python-tornado/Config.in >> @@ -1,7 +1,10 @@ >> config BR2_PACKAGE_PYTHON_TORNADO >> bool "python-tornado" >> - depends on BR2_PACKAGE_PYTHON >> - select BR2_PACKAGE_PYTHON_ZLIB >> + select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime >> + select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3 # runtime >> + select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime >> + select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime >> + select BR2_PACKAGE_PYTHON_CERTIFI # runtime > > Are you sure SSL and certifi are mandatory dependencies? I see the > following things in the source code: > > try: > import ssl > except ImportError: > # ssl is not available on Google App Engine. > ssl = None > > try: > import certifi > except ImportError: > certifi = None > > Which seem to indicate that those Python packages are not mandatory for > python-tornado. They are only needed if you want to do https:// > connexions, no? SSL was really needed by the current version 3.1.1, but this dependency was missing. But you're right tornado devs have fixed this. I'll remove them both then. >> +# Locally computed: >> +sha1 6152ea61b4cdf9566f3974f30603ff51b527dd87 tornado-4.0.2.tar.gz >> +sha256 900c5124ebdb6598ca8e8a0c5888f41a5f14117952d5515258e3d20222b21bfa tornado-4.0.2.tar.gz > > sha256 is sufficient, no need to have sha1 in addition to it. Will remove too. Yegor
diff --git a/package/python-tornado/Config.in b/package/python-tornado/Config.in index 870a3de..9bbfc55 100644 --- a/package/python-tornado/Config.in +++ b/package/python-tornado/Config.in @@ -1,7 +1,10 @@ config BR2_PACKAGE_PYTHON_TORNADO bool "python-tornado" - depends on BR2_PACKAGE_PYTHON - select BR2_PACKAGE_PYTHON_ZLIB + select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime + select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3 # runtime + select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime + select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime + select BR2_PACKAGE_PYTHON_CERTIFI # runtime help Tornado is a Python web framework and asynchronous networking library, originally developed at FriendFeed. diff --git a/package/python-tornado/python-tornado.hash b/package/python-tornado/python-tornado.hash new file mode 100644 index 0000000..361fe11 --- /dev/null +++ b/package/python-tornado/python-tornado.hash @@ -0,0 +1,3 @@ +# Locally computed: +sha1 6152ea61b4cdf9566f3974f30603ff51b527dd87 tornado-4.0.2.tar.gz +sha256 900c5124ebdb6598ca8e8a0c5888f41a5f14117952d5515258e3d20222b21bfa tornado-4.0.2.tar.gz diff --git a/package/python-tornado/python-tornado.mk b/package/python-tornado/python-tornado.mk index bac3ce7..5b88dd6 100644 --- a/package/python-tornado/python-tornado.mk +++ b/package/python-tornado/python-tornado.mk @@ -4,7 +4,7 @@ # ################################################################################ -PYTHON_TORNADO_VERSION = 3.1.1 +PYTHON_TORNADO_VERSION = 4.0.2 PYTHON_TORNADO_SOURCE = tornado-$(PYTHON_TORNADO_VERSION).tar.gz PYTHON_TORNADO_SITE = https://pypi.python.org/packages/source/t/tornado PYTHON_TORNADO_LICENSE = Apache-2.0
Add SSL runtime dependency and a hash file. Also remove obsolete Python dependency statement. Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> --- Changes: v3: add hash origin v2: s/add/remove in commit message package/python-tornado/Config.in | 7 +++++-- package/python-tornado/python-tornado.hash | 3 +++ package/python-tornado/python-tornado.mk | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 package/python-tornado/python-tornado.hash