Patchwork serial/mpc52xx_uart: Drop outdated comments

login
register
mail settings
Submitter Wolfram Sang
Date Jan. 8, 2010, 9:19 p.m.
Message ID <1262985569-29826-1-git-send-email-w.sang@pengutronix.de>
Download mbox | patch
Permalink /patch/42534/
State Superseded
Delegated to: Grant Likely
Headers show

Comments

Wolfram Sang - Jan. 8, 2010, 9:19 p.m.
Most things mentioned are either obsolete (platform-support) or wrong (device
numbering, DCD spport) these days. The remaining rest is obvious.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Grant Likely <grant.likely@secretlab.ca>
---
 drivers/serial/mpc52xx_uart.c |   33 ---------------------------------
 1 files changed, 0 insertions(+), 33 deletions(-)
Wolfram Sang - Feb. 2, 2010, 6:58 p.m.
On Fri, Jan 08, 2010 at 10:19:29PM +0100, Wolfram Sang wrote:
> Most things mentioned are either obsolete (platform-support) or wrong (device
> numbering, DCD spport) these days. The remaining rest is obvious.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Grant Likely <grant.likely@secretlab.ca>

Ping. Anyone interested in this patch?

> ---
>  drivers/serial/mpc52xx_uart.c |   33 ---------------------------------
>  1 files changed, 0 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
> index 7ce9e9f..c7ec1a2 100644
> --- a/drivers/serial/mpc52xx_uart.c
> +++ b/drivers/serial/mpc52xx_uart.c
> @@ -29,39 +29,6 @@
>   * kind, whether express or implied.
>   */
>  
> -/* Platform device Usage :
> - *
> - * Since PSCs can have multiple function, the correct driver for each one
> - * is selected by calling mpc52xx_match_psc_function(...). The function
> - * handled by this driver is "uart".
> - *
> - * The driver init all necessary registers to place the PSC in uart mode without
> - * DCD. However, the pin multiplexing aren't changed and should be set either
> - * by the bootloader or in the platform init code.
> - *
> - * The idx field must be equal to the PSC index (e.g. 0 for PSC1, 1 for PSC2,
> - * and so on). So the PSC1 is mapped to /dev/ttyPSC0, PSC2 to /dev/ttyPSC1 and
> - * so on. But be warned, it's an ABSOLUTE REQUIREMENT ! This is needed mainly
> - * fpr the console code : without this 1:1 mapping, at early boot time, when we
> - * are parsing the kernel args console=ttyPSC?, we wouldn't know which PSC it
> - * will be mapped to.
> - */
> -
> -/* OF Platform device Usage :
> - *
> - * This driver is only used for PSCs configured in uart mode.  The device
> - * tree will have a node for each PSC with "mpc52xx-psc-uart" in the compatible
> - * list.
> - *
> - * By default, PSC devices are enumerated in the order they are found.  However
> - * a particular PSC number can be forces by adding 'device_no = <port#>'
> - * to the device node.
> - *
> - * The driver init all necessary registers to place the PSC in uart mode without
> - * DCD. However, the pin multiplexing aren't changed and should be set either
> - * by the bootloader or in the platform init code.
> - */
> -
>  #undef DEBUG
>  
>  #include <linux/device.h>
> -- 
> 1.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grant Likely - Feb. 2, 2010, 7:06 p.m.
On Tue, Feb 2, 2010 at 11:58 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> On Fri, Jan 08, 2010 at 10:19:29PM +0100, Wolfram Sang wrote:
>> Most things mentioned are either obsolete (platform-support) or wrong (device
>> numbering, DCD spport) these days. The remaining rest is obvious.
>>
>> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>
> Ping. Anyone interested in this patch?

I haven't forgotten, I just haven't gotten around to looking at it.

g.
Wolfram Sang - April 1, 2010, 11:59 p.m.
On Tue, Feb 02, 2010 at 12:06:12PM -0700, Grant Likely wrote:
> On Tue, Feb 2, 2010 at 11:58 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> > On Fri, Jan 08, 2010 at 10:19:29PM +0100, Wolfram Sang wrote:
> >> Most things mentioned are either obsolete (platform-support) or wrong (device
> >> numbering, DCD spport) these days. The remaining rest is obvious.
> >>
> >> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> >> Cc: Grant Likely <grant.likely@secretlab.ca>
> >
> > Ping. Anyone interested in this patch?
> 
> I haven't forgotten, I just haven't gotten around to looking at it.

Ping

Patch

diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index 7ce9e9f..c7ec1a2 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -29,39 +29,6 @@ 
  * kind, whether express or implied.
  */
 
-/* Platform device Usage :
- *
- * Since PSCs can have multiple function, the correct driver for each one
- * is selected by calling mpc52xx_match_psc_function(...). The function
- * handled by this driver is "uart".
- *
- * The driver init all necessary registers to place the PSC in uart mode without
- * DCD. However, the pin multiplexing aren't changed and should be set either
- * by the bootloader or in the platform init code.
- *
- * The idx field must be equal to the PSC index (e.g. 0 for PSC1, 1 for PSC2,
- * and so on). So the PSC1 is mapped to /dev/ttyPSC0, PSC2 to /dev/ttyPSC1 and
- * so on. But be warned, it's an ABSOLUTE REQUIREMENT ! This is needed mainly
- * fpr the console code : without this 1:1 mapping, at early boot time, when we
- * are parsing the kernel args console=ttyPSC?, we wouldn't know which PSC it
- * will be mapped to.
- */
-
-/* OF Platform device Usage :
- *
- * This driver is only used for PSCs configured in uart mode.  The device
- * tree will have a node for each PSC with "mpc52xx-psc-uart" in the compatible
- * list.
- *
- * By default, PSC devices are enumerated in the order they are found.  However
- * a particular PSC number can be forces by adding 'device_no = <port#>'
- * to the device node.
- *
- * The driver init all necessary registers to place the PSC in uart mode without
- * DCD. However, the pin multiplexing aren't changed and should be set either
- * by the bootloader or in the platform init code.
- */
-
 #undef DEBUG
 
 #include <linux/device.h>