From patchwork Fri Jan 8 18:45:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: QMP: Don't free async event's 'data' From: Luiz Capitulino X-Patchwork-Id: 42532 Message-Id: <20100108164553.0ad0fb5d@doriath> To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com Date: Fri, 8 Jan 2010 16:45:53 -0200 The monitor_protocol_event() function will free the event's data, this is wrong as 'data' management is up to the caller. Signed-off-by: Luiz Capitulino --- monitor.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 3af1d5c..2403a97 100644 --- a/monitor.c +++ b/monitor.c @@ -365,8 +365,10 @@ void monitor_protocol_event(MonitorEvent event, QObject *data) qmp = qdict_new(); timestamp_put(qmp); qdict_put(qmp, "event", qstring_from_str(event_name)); - if (data) + if (data) { + qobject_incref(data); qdict_put_obj(qmp, "data", data); + } monitor_json_emitter(mon, QOBJECT(qmp)); QDECREF(qmp);